[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

2017-10-05 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy added a comment. Hi, Could you review/approve this patch, please? I do not have commit permission. I will add other register sets later. Thanks! ;) https://reviews.llvm.org/D38323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

2017-10-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: eugene. labath accepted this revision. labath added a subscriber: eugene. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. Sorry about the delay. @eugene should be able to help you commit this. Wrt. the extra register context dis

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

2017-10-05 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy added a comment. In https://reviews.llvm.org/D38323#889473, @labath wrote: > Looks fine to me. Sorry about the delay. > > @eugene should be able to help you commit this. > > Wrt. the extra register context discussion, I believe you will need to > implement an extra class or two when

[Lldb-commits] [lldb] r315008 - Enable breakpoints and read/write GPRs for ppc64le

2017-10-05 Thread Eugene Zemtsov via lldb-commits
Author: eugene Date: Thu Oct 5 12:44:05 2017 New Revision: 315008 URL: http://llvm.org/viewvc/llvm-project?rev=315008&view=rev Log: Enable breakpoints and read/write GPRs for ppc64le Add support for ppc64le to create breakpoints and read/write general purpose registers. Other features for ppc64l

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

2017-10-05 Thread Eugene Zemtsov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315008: Enable breakpoints and read/write GPRs for ppc64le (authored by eugene). Repository: rL LLVM https://reviews.llvm.org/D38323 Files: lldb/trunk/source/Plugins/Process/Linux/CMakeLists.txt l

[Lldb-commits] [PATCH] D37923: Implement interactive command interruption

2017-10-05 Thread Leonard Mosescu via Phabricator via lldb-commits
lemo updated this revision to Diff 117900. lemo edited the summary of this revision. lemo added a comment. Updating the original changes to handle reentrant calls to CommandInterpreter::IOHandlerInputComplete(). - This fixes bug #34758 - Also enhanced the existing test case for "command source"

[Lldb-commits] [PATCH] D37923: Implement interactive command interruption

2017-10-05 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks fine. https://reviews.llvm.org/D37923 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D37923: Implement interactive command interruption

2017-10-05 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth accepted this revision. amccarth added a comment. LGTM https://reviews.llvm.org/D37923 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D37923: Implement interactive command interruption

2017-10-05 Thread Leonard Mosescu via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315037: Implement interactive command interruption (authored by lemo). Changed prior to commit: https://reviews.llvm.org/D37923?vs=117900&id=117936#toc Repository: rL LLVM https://reviews.llvm.org/D

[Lldb-commits] [lldb] r315037 - Implement interactive command interruption

2017-10-05 Thread Leonard Mosescu via lldb-commits
Author: lemo Date: Thu Oct 5 16:41:28 2017 New Revision: 315037 URL: http://llvm.org/viewvc/llvm-project?rev=315037&view=rev Log: Implement interactive command interruption The core of this change is the new CommandInterpreter::m_command_state, which models the state transitions for interactive