petpav01 added inline comments.
Comment at: source/Utility/DataExtractor.cpp:566
size_t byte_size) const {
- switch (byte_size) {
- case 1:
-return GetU8(offset_ptr);
-break;
- case 2:
-return GetU16(offset_ptr);
-break;
- ca
lemo created this revision.
Herald added a subscriber: mgorny.
Neither LLDB_CONFIGURATION_DEBUG nor LLDB_CONFIGURATION_RELEASE were ever set
in the CMake LLDB project.
Also cleaned up a questionable #ifdef in SharingPtr.h, removing all the
references to LLDB_CONFIGURATION_BUILD_AND_INTEGRATION
zturner added inline comments.
Comment at: CMakeLists.txt:15
+# Define the LLDB_CONFIGURATION_xxx matching the build type
+if( uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" )
+ add_definitions( -DLLDB_CONFIGURATION_DEBUG )
I'm pretty sure that if you run CMake wit
lemo added a comment.
Good point, I wouldn't be surprised if that was the case at some point, but
right now the main llvm CMakeLists.txt has this:
...
if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
message(STATUS "No build type selected, default to Debug")
set(CMAKE_BUILD_TYPE
lemo updated this revision to Diff 117704.
lemo added a comment.
Changed how CMAKE_BUILD_TYPE is tested to ensure we default to
LLDB_CONFIGURATION_DEBUG.
https://reviews.llvm.org/D38552
Files:
CMakeLists.txt
include/lldb/Utility/SharingPtr.h
Index: include/lldb/Utility/SharingPtr.h
=
zturner added inline comments.
Comment at: CMakeLists.txt:15
+# Define the LLDB_CONFIGURATION_xxx matching the build type
+if( NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" )
+ add_definitions( -DLLDB_CONFIGURATION_RELEASE )
Isn't this identical to the code be
Identical, no - note the checks are inverted. Definitely uglier, but it's
defaulting to LLDB_CONFIGURATION_DEBUG if CMAKE_BUILD_TYPE is not defined,
right?
With the current defaulting rule I pointed out both versions should be
equivalent. If anything I prefer the 1st version since I like to avoid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314929: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based
on the build type (authored by lemo).
Changed prior to commit:
https://reviews.llvm.org/D38552?vs=117704&id=117730#toc
Repository:
rL LLVM
Author: lemo
Date: Wed Oct 4 13:23:56 2017
New Revision: 314929
URL: http://llvm.org/viewvc/llvm-project?rev=314929&view=rev
Log:
LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type
Neither LLDB_CONFIGURATION_DEBUG nor LLDB_CONFIGURATION_RELEASE were ever set
in the CMake LLDB
alexshap created this revision.
Herald added subscribers: JDevlieghere, aprantl.
Previously LLDB required dwp to be located next to the executable file
(see the code in SymbolFileDWARF::GetDwpSymbolFile).
This diff uses the helper function Symbols::LocateExecutableSymbolFile
to search for DWP file
Author: jingham
Date: Wed Oct 4 17:49:49 2017
New Revision: 314958
URL: http://llvm.org/viewvc/llvm-project?rev=314958&view=rev
Log:
Another silly little thing you can do with Python commands.
Sometimes you want to step along and print a local each time as you go.
You can do that with stop hooks
Author: jingham
Date: Wed Oct 4 18:00:29 2017
New Revision: 314959
URL: http://llvm.org/viewvc/llvm-project?rev=314959&view=rev
Log:
Work around a bug in the C++ expression parser.
When the expression parser does name resolution for local
variables in C++ closures it doesn't give the local name
12 matches
Mail list logo
