[Lldb-commits] [PATCH] D38153: Inhibit global lookups for symbols in the IR dynamic checks

2017-09-25 Thread Sean Callanan via Phabricator via lldb-commits
spyffe marked 5 inline comments as done. spyffe added a comment. Thank you. I am testing a new revision with your suggestions. Repository: rL LLVM https://reviews.llvm.org/D38153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

2017-09-25 Thread Stephane Sezer via Phabricator via lldb-commits
sas updated this revision to Diff 116440. sas added a comment. Rebase + clang-format. https://reviews.llvm.org/D22231 Files: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp Index: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp =

[Lldb-commits] [PATCH] D38153: Inhibit global lookups for symbols in the IR dynamic checks

2017-09-25 Thread Sean Callanan via Phabricator via lldb-commits
spyffe updated this revision to Diff 116444. spyffe added a comment. Applied Greg's and Zachary's suggestions: - Used `R"(...)"` for multiline strings. - Used `StringRef`s appropriately. - Factored out symbol-ignoring into a function shared between `ClangASTSource` and `ClangExpressionDeclMap`.

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-09-25 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie added a comment. In https://reviews.llvm.org/D33213#873962, @jingham wrote: > Pavel & Eugene haven't marked it accepted yet, but from the comments is looks > like they are both okay with the change. So it looks to me like everything > is done but checking the code in. > > If you have

[Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

2017-09-25 Thread Stephane Sezer via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314045: Implement trampoline step-through for Windows-x86. (authored by sas). Repository: rL LLVM https://reviews.llvm.org/D22231 Files: lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/Dynamic

[Lldb-commits] [PATCH] D38153: Inhibit global lookups for symbols in the IR dynamic checks

2017-09-25 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Looks good. Repository: rL LLVM https://reviews.llvm.org/D38153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-09-25 Thread Eugene Zemtsov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314127: Use socketpair on all Unix platforms (authored by eugene). Repository: rL LLVM https://reviews.llvm.org/D33213 Files: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb

[Lldb-commits] [lldb] r314127 - Use socketpair on all Unix platforms

2017-09-25 Thread Eugene Zemtsov via lldb-commits
Author: eugene Date: Mon Sep 25 10:41:16 2017 New Revision: 314127 URL: http://llvm.org/viewvc/llvm-project?rev=314127&view=rev Log: Use socketpair on all Unix platforms Using TCP sockets is insecure against local attackers, and possibly against remote attackers too (some vulnerabilities may allo

[Lldb-commits] [lldb] r314155 - Remove the details of the libstdc++ implementation that were

2017-09-25 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Sep 25 14:23:37 2017 New Revision: 314155 URL: http://llvm.org/viewvc/llvm-project?rev=314155&view=rev Log: Remove the details of the libstdc++ implementation that were in TestDataFormatterSkipSummary.py - I'm building this test with the default c++ library. Skip TestMT