clayborg added a comment.
Yes: lldbassert would be fine for that since those get compiled out during
release. Patch looks fine. If we already have a test that would trigger the new
"lldbassert" you will add, then no need for a special test for this, else we
need a test that triggers this.
Rep
jafl added a comment.
I will try to ensure that the lldbassert gets tested, but right now, none of
the tests work on my machine. I emailed lldb-dev for help.
Repository:
rL LLVM
https://reviews.llvm.org/D32366
___
lldb-commits mailing list
lldb
jafl updated this revision to Diff 112922.
jafl added a comment.
Added lldbassert
https://reviews.llvm.org/D32366
Files:
source/Commands/CommandObjectRegister.cpp
source/Interpreter/CommandInterpreter.cpp
Index: source/Interpreter/CommandInterpreter.cpp
===
clayborg added a comment.
This is sure to trigger things in the test suite. We will need to ensure a few
things:
- test suite runs cleanly in debug mode after the lldbassert is added
- without changes to CommandObjectRegister.cpp that the lldbassert is
triggered, and if not, add a test
https:
jafl added a comment.
Absolutely!
https://reviews.llvm.org/D32366
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Mon Aug 28 21:28:48 2017
New Revision: 311978
URL: http://llvm.org/viewvc/llvm-project?rev=311978&view=rev
Log:
update xpc service name.
Modified:
lldb/trunk/source/Host/macosx/Host.mm
Modified: lldb/trunk/source/Host/macosx/Host.mm
URL:
http://llvm.org/viewvc/llvm-pr
vbalu requested changes to this revision.
vbalu added a comment.
This revision now requires changes to proceed.
if (::sysctl(mib, 4, pathname, &len, NULL, 0) == 0)
"len" is not declared. Please change to "pathname_len".
https://reviews.llvm.org/D32271
__
