Author: kuba.brecka
Date: Tue Aug 22 11:36:12 2017
New Revision: 311483
URL: http://llvm.org/viewvc/llvm-project?rev=311483&view=rev
Log:
[lldb] Correctly escape newlines and backslashes in the JSON serializer
JSON serializer fails to escape newlines and backslashes. Let's fix that.
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311483: [lldb] Correctly escape newlines and backslashes in
the JSON serializer (authored by kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D34322?vs=102950&id=112206#toc
Repository:
gut added a comment.
In https://reviews.llvm.org/D36804#845286, @gut wrote:
> Can I please get some review on this?
>
> ps: check comments on phabricator as it was not being published on
> lldb-commits mailing list.
Nobody? It's a very small change.
We hope to port LLDB to PowerPC64le if patc
krytarowski added reviewers: labath, clayborg.
krytarowski added a comment.
+ Linux and general LLDB maintainers
https://reviews.llvm.org/D36804
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: kuba.brecka
Date: Tue Aug 22 12:09:39 2017
New Revision: 311484
URL: http://llvm.org/viewvc/llvm-project?rev=311484&view=rev
Log:
Fixup for r311483: Use correct path to StreamString.h
Modified:
lldb/trunk/unittests/Utility/JSONTest.cpp
Modified: lldb/trunk/unittests/Utility/JSONTest
hfinkel added inline comments.
Comment at: source/Core/ArchSpec.cpp:375
SUBTYPE_MASK},
+{ArchSpec::eCore_ppc64le_generic, llvm::MachO::CPU_TYPE_POWERPC64, CPU_ANY,
+ UINT32_MAX, SUBTYPE_MASK},
I doubt this is needed. There's no Darwin support to spe
gut added inline comments.
Comment at: source/Core/ArchSpec.cpp:375
SUBTYPE_MASK},
+{ArchSpec::eCore_ppc64le_generic, llvm::MachO::CPU_TYPE_POWERPC64, CPU_ANY,
+ UINT32_MAX, SUBTYPE_MASK},
hfinkel wrote:
> I doubt this is needed. There's no Darwin s
hfinkel accepted this revision.
hfinkel added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Core/ArchSpec.cpp:375
SUBTYPE_MASK},
+{ArchSpec::eCore_ppc64le_generic, llvm::MachO::CPU_TYPE_POWERPC64, CPU_ANY,
+ UINT32_MAX, SUBTYPE