gut added a comment.
Can I please get some review on this?
ps: check comments on phabricator as it was not being published on lldb-commits
mailing list.
https://reviews.llvm.org/D36804
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
mgorny created this revision.
mgorny added a project: LLDB.
Add explicit linkage to the necessary system libraries in the Host
library. Otherwise, the library fails to build with -Wl,--as-needed.
The system libraries ended up being listed on the linker command-line
before the static libraries need
mgorny created this revision.
mgorny added a project: LLDB.
The Process/gdb-remote test now requires the LLVMTestingSupport library
that is not installed by LLVM. As a result, when doing an out-of-source
build it fails being unable to find the library. To solve that, build
a local copy of the libr
Author: jmolenda
Date: Fri Aug 18 15:57:59 2017
New Revision: 311207
URL: http://llvm.org/viewvc/llvm-project?rev=311207&view=rev
Log:
Commiting Christopher Brook's patch for
"Prevent negative chars from being sign-extended into isprint and isspace which
take and int and crash if the int is nega
jasonmolenda closed this revision.
jasonmolenda added a comment.
Sendingsource/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
Transmitting file data .done
Committing transaction...
Committed revision 311207.
https://reviews.llvm.org/D36620
__
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Seems fine to me, beanz?
Repository:
rL LLVM
https://reviews.llvm.org/D36886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
zturner added inline comments.
Comment at: source/Host/CMakeLists.txt:166-168
+ if (LIBXML2_FOUND)
+list(APPEND EXTRA_LIBS ${LIBXML2_LIBRARIES})
+ endif()
Even if libxml is found, that doesn't mean the build is configured to use it,
does it? Correct me if
