[Lldb-commits] [lldb] r309554 - Add support for base address entries in the .debug_ranges section

2017-07-31 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jul 31 03:26:19 2017 New Revision: 309554 URL: http://llvm.org/viewvc/llvm-project?rev=309554&view=rev Log: Add support for base address entries in the .debug_ranges section Summary: Clang recently started to emit base address entries into the .debug_ranges section t

[Lldb-commits] [PATCH] D36068: Add support for base address entries in the .debug_ranges section

2017-07-31 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added a comment. Submitted as https://reviews.llvm.org/rL309554 to get the buildbot using ToT clang green again but if you have any comment then let me know and I will address it in a followup CL. https://reviews.llvm.org/D36068 ___ ll

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-07-31 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D35784#823131, @clayborg wrote: > So the issue is with the ObjectFileELF when it makes its symbol table. It is > taking this symbols: > > 49686: bcf0 0 NOTYPE LOCAL DEFAULT 40 $debug_ranges627 > > > And saying it is a code sy

[Lldb-commits] [PATCH] D36046: Improve the posix core file triple detection

2017-07-31 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735 + if (target_arch.IsMIPS()) { return target_arch; + } tberghammer wrote: > Hi Nitesh, > > I tried to remove this MIPS specific code as it shouldn't b

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-07-31 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Hi Tamas, > Run "target modules list" (lldb) target modules list [ 0] E6A47987---- /export/tmp/nin/LLVM/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/multiset/a.out

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-07-31 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. The android version am using for testing is "O". generic_mips64:/ # getprop ro.build.version.release O Repository: rL LLVM https://reviews.llvm.org/D11465 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-07-31 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added a comment. Thanks for all of the data. Based on this I think you are using a preview version of android O what reports SDK 25 but the linker works the way an SDK 26 system linker would do. I think the proper fix for the problem is to do something like what Greg suggested to d

[Lldb-commits] [lldb] r309631 - [build-script] Bring in modernizations from downstream:

2017-07-31 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Jul 31 14:50:00 2017 New Revision: 309631 URL: http://llvm.org/viewvc/llvm-project?rev=309631&view=rev Log: [build-script] Bring in modernizations from downstream: - Don't do any checks of the current SCM repository if the llvm repositories are already there. Useful fo

[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene created this revision. eugene added a project: LLDB. https://reviews.llvm.org/D36126 Files: source/Symbol/Symtab.cpp Index: source/Symbol/Symtab.cpp === --- source/Symbol/Symtab.cpp +++ source/Symbol/Symtab.cpp @@ -616,8 +

[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This bug has been there since the first llvm.org checkin. I'm curious, did it actually cause a problem or did you just see it while reading? The patch is right. Most of the other uses elid

[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene added a comment. clang drew my attention to it: Symtab.cpp:620:5: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] std::unique(indexes.begin(), indexes.end()); ^~~ ~~ https://reviews.llvm.o

[Lldb-commits] [lldb] r309648 - Fix incorrect use of std::unique

2017-07-31 Thread Eugene Zemtsov via lldb-commits
Author: eugene Date: Mon Jul 31 18:29:55 2017 New Revision: 309648 URL: http://llvm.org/viewvc/llvm-project?rev=309648&view=rev Log: Fix incorrect use of std::unique Modified: lldb/trunk/source/Symbol/Symtab.cpp Modified: lldb/trunk/source/Symbol/Symtab.cpp URL: http://llvm.org/viewvc/llvm-

[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene closed this revision. eugene added a comment. Checked in as r309648 https://reviews.llvm.org/D36126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-31 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene accepted this revision. eugene added a comment. LGTM. Test run on Linux is clear. I also see a bit of perf bump. Before checking in please remove outdated comment from ProcessGDBRemote::LaunchAndConnectToDebugserver. // Use a socketpair on Apple for now until other platforms can verify