[Lldb-commits] [PATCH] D36046: Improve the posix core file triple detection

2017-07-29 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer created this revision. Herald added subscribers: kristof.beyls, arichardson, sdardis, aemerson. Posix core files sometime don't contain enough information to correctly detect the OS. If that is the case we should use the OS from the target instead as it will contain usable information

[Lldb-commits] [PATCH] D36046: Improve the posix core file triple detection

2017-07-29 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735 + if (target_arch.IsMIPS()) { return target_arch; + } Hi Nitesh, I tried to remove this MIPS specific code as it shouldn't be necessary if I add the

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-29 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie updated this revision to Diff 108796. DemiMarie added a comment. Set FD_CLOEXEC on the communication fd https://reviews.llvm.org/D33213 Files: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp =