[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-07-25 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Two issues we need to resolve: - I don't think AddressClass should have Absolute as a value. Absolute values in symbol tables are just numbers, not necessarily addresses. - This

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-07-25 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In your log we see: [10] .text PROGBITS bb80 bb80 00054380 AX 0 0 16 [30] .debug_arangesMIPS_DWARF 0006c24c 0560 0

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-07-25 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. (in the above log output .text has a valid address, but .debug_aranges doesn't. We might need to cross correlate withe the program headers to tell if something gets loaded (PT_LOAD) for a given file address. What does the output of: (lldb) image dump sections look l

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-25 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie updated this revision to Diff 108094. DemiMarie added a comment. Initalize connection_fd Otherwise undefined behavior ensues whenever --fd is not passed to lldb-server -g. https://reviews.llvm.org/D33213 Files: tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdb

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-07-25 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Looking at an ELF file with DWARF, I see: (lldb) image dump sections Dumping sections for 1 modules. Sections for '/Volumes/android/aosp/out/target/product/generic/symbols/system/lib/libart.so' (arm): SectID Type File Address

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-25 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. So where did the other changes go where we use "--fd" for non Apple builds? Did those changes get lost? They will be needed. Are you able to run the test suite now? https://reviews.llvm.org/D33213 ___ lldb-commits mailing

[Lldb-commits] [lldb] r308993 - [TypeSystem] Guard the global `ASTSourceMap` with a mutex

2017-07-25 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jul 25 10:33:37 2017 New Revision: 308993 URL: http://llvm.org/viewvc/llvm-project?rev=308993&view=rev Log: [TypeSystem] Guard the global `ASTSourceMap` with a mutex s_source_map in ClangExternalASTSourceCommon.cpp is unguarded and therefore can break in multithreaded co

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

2017-07-25 Thread Sean Callanan via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308993: [TypeSystem] Guard the global `ASTSourceMap` with a mutex (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D35083?vs=106087&id=108116#toc Repository: rL LLVM https://r

[Lldb-commits] [lldb] r309019 - Improve the fix for PR33875 by not hardcoding the section name.

2017-07-25 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Tue Jul 25 13:12:25 2017 New Revision: 309019 URL: http://llvm.org/viewvc/llvm-project?rev=309019&view=rev Log: Improve the fix for PR33875 by not hardcoding the section name. This is a follow-up to r308905. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileD

[Lldb-commits] [lldb] r309020 - [CMake] Add debugserver entitlements

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:29:28 2017 New Revision: 309020 URL: http://llvm.org/viewvc/llvm-project?rev=309020&view=rev Log: [CMake] Add debugserver entitlements When consigning debugserver we should also include the entitlements file on the code sign command. Modified: lldb/trun

[Lldb-commits] [lldb] r309021 - [CMake] Cleanup unnecessary definition

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:29:45 2017 New Revision: 309021 URL: http://llvm.org/viewvc/llvm-project?rev=309021&view=rev Log: [CMake] Cleanup unnecessary definition This is only used in one file, and we already set it correctly on that file, so we don't need to set this everywhere. Mo

[Lldb-commits] [lldb] r309022 - [CMake] NFC. Cleanup unnecessary CMake policy

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:30:18 2017 New Revision: 309022 URL: http://llvm.org/viewvc/llvm-project?rev=309022&view=rev Log: [CMake] NFC. Cleanup unnecessary CMake policy This is just setting to the default behavior, so it does nothing. Modified: lldb/trunk/cmake/modules/LLDBStand

[Lldb-commits] [lldb] r309023 - [CMake] Fix framework build

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:30:35 2017 New Revision: 309023 URL: http://llvm.org/viewvc/llvm-project?rev=309023&view=rev Log: [CMake] Fix framework build The LLDB framework build looks for the swig-generated source in the wrong place. This should resolve that. Modified: lldb/trunk

[Lldb-commits] [lldb] r309024 - [CMake] Rework construction of framework bundle

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:30:58 2017 New Revision: 309024 URL: http://llvm.org/viewvc/llvm-project?rev=309024&view=rev Log: [CMake] Rework construction of framework bundle This adds an explicit step for processing the headers and restructures how the framework bundles are constructed

[Lldb-commits] [lldb] r309025 - [CMake] Update Framework construction for iOS

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:31:15 2017 New Revision: 309025 URL: http://llvm.org/viewvc/llvm-project?rev=309025&view=rev Log: [CMake] Update Framework construction for iOS On iOS frameworks don't have versions or resources, they are flatter bundles. This updates the LLDB framework buil

[Lldb-commits] [lldb] r309026 - [CMake] Build debugserver & debugserver_nonui

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:31:53 2017 New Revision: 309026 URL: http://llvm.org/viewvc/llvm-project?rev=309026&view=rev Log: [CMake] Build debugserver & debugserver_nonui When building for iOS we build two variants of debugserver. One which supports UI functionality like Springboard f

[Lldb-commits] [lldb] r309046 - Skip test_unique_stacks on Darwin, because it doesn't terminate reliably.

2017-07-25 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jul 25 15:44:34 2017 New Revision: 309046 URL: http://llvm.org/viewvc/llvm-project?rev=309046&view=rev Log: Skip test_unique_stacks on Darwin, because it doesn't terminate reliably. rdar://problem/33462362 Modified: lldb/trunk/packages/Python/lldbsuite/test/function

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-25 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie updated this revision to Diff 108214. DemiMarie added a comment. Actually use socketpair :) https://reviews.llvm.org/D33213 Files: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp =

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-25 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie added a comment. In https://reviews.llvm.org/D33213#820238, @clayborg wrote: > So where did the other changes go where we use "--fd" for non Apple builds? > Did those changes get lost? They will be needed. > > Are you able to run the test suite now? I did. Not all tests passed, but