nitesh.jain created this revision.
Herald added subscribers: arichardson, sdardis.
The implementation of Address::GetAddressClass() is based on file address.
Those it will give incorrect result if there are more than one section for a
particular file address. For example (see attach log), there
tberghammer added a comment.
This section have been already removed from Dwarf5 so I agree that we shouldn't
spend too much time adding support for it. Do you know anybody hitting this
issue? Do you know why they decided to use this flag?
Comment at: source/Plugins/SymbolFile
clayborg added a comment.
We have been hitting this at Facebook for server apps that statically link the
entire world (libc, libc++, libstdc++, all other needed shared libraries) as
the debug info is too large unless -fdebug-types-section is used.
Comment at: source/Plugins/S
Author: gclayton
Date: Mon Jul 24 09:47:04 2017
New Revision: 308896
URL: http://llvm.org/viewvc/llvm-project?rev=308896&view=rev
Log:
Don't crash when hostname is empty. StringRef will assert and kill your program.
Modified:
lldb/trunk/source/Utility/UriParser.cpp
Modified: lldb/trunk/sour
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please init fd
Comment at: tools/lldb-server/lldb-gdbserver.cpp:388
bool reverse_connect = false;
+ int connection_fd;
This must be initi
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Can you file a bug about this issue so we can keep track of it? Also it would
be nice to include a small test case in the bug (if you have one) what
demonstrates the crash as so far
clayborg added a comment.
The enum might need to be scoped outside the function or in a header file...
https://reviews.llvm.org/D35734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
clayborg added a comment.
I believe a crash looks like:
#include
int main(int argc, const char **argv) {
typedef enum FooTag {
Bar,
Baz
} Foo;
Foo foo = Bar;
printf("foo = %i\n", foo);
return 0; // Break here and "frame variable"
}
The enum gets put into
jingham added a comment.
Huh, not sure how the other comment vanished. I was concerned that
"GetAvailablePlatformAtIndex" didn't actually get a platform, so the name was
confusing. I suggested GetAvailablePlatformInfoAtIndex as more accurate.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: adrian
Date: Mon Jul 24 11:06:39 2017
New Revision: 308905
URL: http://llvm.org/viewvc/llvm-project?rev=308905&view=rev
Log:
RFix PR33875 by distinguishing between DWO and clang modules.
This reapplies https://reviews.llvm.org/D35740 with a tweak to find
the section by name rather than ty
Author: gclayton
Date: Mon Jul 24 11:40:33 2017
New Revision: 308911
URL: http://llvm.org/viewvc/llvm-project?rev=308911&view=rev
Log:
Don't allow .debug_types to be parsed as LLDB can crash when enums are not able
to be found.
Differential Revision: https://reviews.llvm.org/D35734
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308911: Don't allow .debug_types to be parsed as LLDB can
crash when enums are not able… (authored by gclayton).
Changed prior to commit:
https://reviews.llvm.org/D35734?vs=107710&id=107936#toc
Reposit
probinson added a comment.
In https://reviews.llvm.org/D35734#818778, @tberghammer wrote:
> This section have been already removed from Dwarf5 so I agree that we
> shouldn't spend too much time adding support for it.
Compilers wanting to use type units and DWARF 4 should be emitting them in th
clayborg added a comment.
In https://reviews.llvm.org/D35734#819193, @probinson wrote:
> In https://reviews.llvm.org/D35734#818778, @tberghammer wrote:
>
> > This section have been already removed from Dwarf5 so I agree that we
> > shouldn't spend too much time adding support for it.
>
>
> Compi
Author: spyffe
Date: Mon Jul 24 13:11:20 2017
New Revision: 308919
URL: http://llvm.org/viewvc/llvm-project?rev=308919&view=rev
Log:
Skip test_lldbmi_var_update on Darwin.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py
Modified:
lldb/trunk/packages/
eugene added a comment.
Greg, are you with me checking this in?
https://reviews.llvm.org/D35607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
> Greg, are you with me checking this in?
Sure thing
https://reviews.llvm.org/D35607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308933: Extend 'target symbols add' to load symbols from a
given module (authored by eugene).
Changed prior to commit:
https://reviews.llvm.org/D35607?vs=107725&id=107983#toc
Repository:
rL LLVM
htt
Author: eugene
Date: Mon Jul 24 15:52:39 2017
New Revision: 308933
URL: http://llvm.org/viewvc/llvm-project?rev=308933&view=rev
Log:
Extend 'target symbols add' to load symbols from a given module
Now -shlib flag can be provided alongside with names of symbols files:
(lldb) target symbols add --
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Ack! I thought when you said you were "going to simply pass..." you hadn't
done it yet, so I didn't look at the source changes.
Anyway, this looks fine to me.
Repository:
rL LLVM
https
20 matches
Mail list logo
