Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

2017-07-23 Thread Adrian Prantl via lldb-commits
> On Jul 22, 2017, at 2:26 PM, David Blaikie wrote: > > > > On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham > wrote: > Not at present, but you presumably know more about this than I do. Part of > the point of Greg's extracting the DWARF parser from lldb and making it in

[Lldb-commits] [lldb] r308850 - Fix PR33875 by distinguishing between DWO and clang modules

2017-07-23 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Sun Jul 23 10:59:07 2017 New Revision: 308850 URL: http://llvm.org/viewvc/llvm-project?rev=308850&view=rev Log: Fix PR33875 by distinguishing between DWO and clang modules The DWO handling code can get confused by clang modules which also use skeleton CUs to point to the obje

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

2017-07-23 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308850: Fix PR33875 by distinguishing between DWO and clang modules (authored by adrian). Changed prior to commit: https://reviews.llvm.org/D35740?vs=107734&id=107836#toc Repository: rL LLVM https:/

[Lldb-commits] [lldb] r308851 - Revert "Fix PR33875 by distinguishing between DWO and clang modules"

2017-07-23 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Sun Jul 23 13:24:41 2017 New Revision: 308851 URL: http://llvm.org/viewvc/llvm-project?rev=308851&view=rev Log: Revert "Fix PR33875 by distinguishing between DWO and clang modules" This reverts commit r308850. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp

[Lldb-commits] [PATCH] D35760: Expose active and available platform lists via SBDebugger API

2017-07-23 Thread Vadim Macagon via Phabricator via lldb-commits
enlight added a comment. Thanks for the review Jim, but I only see the testing suggestion, could you elaborate on the other two issues? Repository: rL LLVM https://reviews.llvm.org/D35760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

2017-07-23 Thread David Blaikie via lldb-commits
On Sun, Jul 23, 2017 at 10:54 AM Adrian Prantl wrote: > On Jul 22, 2017, at 2:26 PM, David Blaikie wrote: > > > > On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham wrote: > >> Not at present, but you presumably know more about this than I do. Part >> of the point of Greg's extracting the DWARF parser