[Lldb-commits] [PATCH] D35760: Expose active and available platform lists via SBDebugger API

2017-07-22 Thread Vadim Macagon via Phabricator via lldb-commits
enlight updated this revision to Diff 107789. enlight added a comment. Update packages/Python/lldbsuite/test/python_api/default-constructor/sb_debugger.py Repository: rL LLVM https://reviews.llvm.org/D35760 Files: include/lldb/API/SBDebugger.h include/lldb/API/SBStructuredData.h packa

[Lldb-commits] [PATCH] D35760: Expose active and available platform lists via SBDebugger API

2017-07-22 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This seems fine. I have a little quibble with the name, inline, and a testing suggestion. Comment at: packages/Python/lldbsuite/test/functionalities/platform/T

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

2017-07-22 Thread David Blaikie via lldb-commits
On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham wrote: > Not at present, but you presumably know more about this than I do. Part > of the point of Greg's extracting the DWARF parser from lldb and making it > into it's own library in llvm was precisely so that somebody could then > write a simple wrap

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-22 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie updated this revision to Diff 107805. DemiMarie added a comment. Fix connection when there is no host:port https://reviews.llvm.org/D33213 Files: source/Host/posix/ConnectionFileDescriptorPosix.cpp tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp =

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-22 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie updated this revision to Diff 107806. DemiMarie added a comment. Get rid of silly and bogus #error https://reviews.llvm.org/D33213 Files: tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp ===