Re: [Lldb-commits] [lldb] r247852 - Add an OperatingSystem plugin to support goroutines

2017-07-14 Thread Pavel Labath via lldb-commits
Hi Jason, I believe Ryan is no longer working for google. Since the go plugin was his effort, I think that unfortunately leaves our go support without a maintainer. (Unless he happens to be reading this from a personal email). I have also recently disabled one of the go tests because it was failin

[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

2017-07-14 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 106600. labath marked an inline comment as done. labath added a comment. The version with a container object for ArchSpec+Plugin combo https://reviews.llvm.org/D31172 Files: include/lldb/Core/ArchSpec.h include/lldb/Core/Architecture.h include/lldb/Cor

[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

2017-07-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D31172#808177, @clayborg wrote: > In https://reviews.llvm.org/D31172#808105, @labath wrote: > > > - confine all the changes to m_arch to the SetArchitecture method. Right > > now only one of the assignments to m_arch is done outside of this met

Re: [Lldb-commits] [lldb] r247852 - Add an OperatingSystem plugin to support goroutines

2017-07-14 Thread Jason Molenda via lldb-commits
Thanks Pavel, I got a bounce from his work email too. I agree with your plan for this, I think this is the first time that we have a plugin/target without an active maintainer that may be bitrotting or in need of maintenance. I was experimenting with disabling the goroutine threads, the change f

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-14 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie updated this revision to Diff 106708. DemiMarie added a comment. Make --fd an alias for --pipe https://reviews.llvm.org/D33213 Files: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp =

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-14 Thread Demi Marie Obenour via Phabricator via lldb-commits
DemiMarie added a comment. In https://reviews.llvm.org/D33213#806807, @clayborg wrote: > Ah yes, I thought there was something missing... I just made `--fd` an alias for `--pipe`. https://reviews.llvm.org/D33213 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Let Pavel try this and verify and this is good to go. https://reviews.llvm.org/D33213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Any news on any speed changes? Please post the output of: (lldb) process plugin packet speed-test Both without and with this change. Nice to track any perf improvements https://reviews.llvm.org/D33213 ___ lldb-commits m