[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool. thanks https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D35113: Clean up lldb-types.h

labath added a comment. Comment at: include/lldb/Host/MainLoop.h:16 #include "llvm/ADT/DenseMap.h" +#include Eugene.Zelenko wrote: > I think will be good idea to include csignal instead. Same in other files. > See > http://clang.llvm.org/extra/clang-tidy

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added a comment. @labath @joerg thanks for the review. Can anyone commit this, please? I still don't have commit privileges. https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D35123: Remove shared pointer from NativeProcessProtocol

krytarowski added a comment. I have no particular opinion on it. If it builds and works, I'm fine with it. https://reviews.llvm.org/D35123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

clayborg added a comment. Much better on the API with Swig. Just a few inlined questions around GetRawBytes. Comment at: tools/intel-features/intel-pt/PTDecoder.h:54-55 + + // Get raw bytes of the instruction + const uint8_t *GetRawBytes() const; + In the py

[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

clayborg added a comment. Looks good. Just one question on why we register a packet handler. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:32-35 + RegisterPacketHandler( + StringExtractorGDBRemote::eServerPacketType_QEnableErrorStrings, +

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

jingham added a comment. In https://reviews.llvm.org/D35083#802439, @spyffe wrote: > Responded to Lang's comments inline. > > **Jim**: you say this patch "doesn't actually enforce that you take the lock > to get the SourceMap." How do you get the source map otherwise? It's static > inside the

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

karnajitw created this revision. Herald added a subscriber: emaste. This is the freebsd equivalent of https://reviews.llvm.org/rL238549. The fix serves 2 purpose 1. LLDB should handle inferior process signals SIGSEGV/SIGILL/SIGBUS/SIGFPE the way it is suppose to be handled. Prior to this fix th

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

karnajitw added a comment. Adding the associated bugzilla link for this issue https://bugs.llvm.org/show_bug.cgi?id=23699 [Before Fix] [/home/karnajitw/llvm_50_public/build.symbol] $ bin/lldb ~/lldb_test_execs/sigsegv (lldb) target create "/home/karnajitw/lldb_test_execs/sigsegv" Current executa

[Lldb-commits] [PATCH] D35036: switch on enum should be exhaustive and warning-free

penryu requested review of this revision. penryu added a comment. This revision is now accepted and ready to land. I need to learn more about the number formatters before I make more significant changes than those below. As written currently, it leaves the logic intact and resolves the warning.

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

lhames added a comment. I prefer the lambda syntax: Locking with an argument requires you to know the idiom (which wasn't immediately obvious to me), whereas the lambda enforces it implicitly. We could also consider writing an atomic access adapter for this (and other types). That would be gen

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

jingham added a comment. This is a fairly common idiom in lldb and seems to me quite obvious. If the API to get an object requires a lock guard of some sort, then you have to hold the lock while using the object. As a general practice requiring a wrapper like this for every use of a should be

[Lldb-commits] [lldb] r307618 - Pass in the disassembler flavor when disassembling in

Author: jmolenda Date: Mon Jul 10 21:22:31 2017 New Revision: 307618 URL: http://llvm.org/viewvc/llvm-project?rev=307618&view=rev Log: Pass in the disassembler flavor when disassembling in DumpDataExtractor. Patch from Jeffrey Crowell, https://reviews.llvm.org/D34929 Modified: lldb/trunk/so

[Lldb-commits] [PATCH] D34929: respect target.x86-disassembly-flavor when using `memory read`

jasonmolenda closed this revision. jasonmolenda added a comment. I committed this for Jeffrey in r307618. Repository: rL LLVM https://reviews.llvm.org/D34929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[Lldb-commits] Buildbot numbers for the week of 06/25/2017 - 07/1/2017

Hello everyone, Below are some buildbot numbers for the week of 06/25/2017 - 07/1/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gree

[Lldb-commits] Buildbot numbers for the last week of 07/02/2017 - 07/08/2017

Hello everyone, Below are some buildbot numbers for the last week of 07/02/2017 - 07/08/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro