labath created this revision.
Herald added a subscriber: mgorny.
The new UndefinedBehaviorSanitizer plugin was breaking file path length
limits, because it's (fairly long name) appears multiple times in the
path. Cmake ends up putting the object file at path
tools/lldb/source/Plugins/Instrumentati
No objections here
On Fri, Jun 23, 2017 at 5:48 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath created this revision.
> Herald added a subscriber: mgorny.
>
> The new UndefinedBehaviorSanitizer plugin was breaking file path length
> limits, because it's (fairly long na
kubamracek added a comment.
Oh wow, we really need to limit path lengths? What about files like
`./packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/breakpoints_delayed_breakpoint_one_watchpoint/TestConcurrentBreakpointsDelayedBreakpointOneWatchpoint.py`?
https://reviews.
labath added a comment.
In https://reviews.llvm.org/D34553#789023, @kubamracek wrote:
> Oh wow, we really need to limit path lengths?
It's a bit annoying, but windows has issues with paths like that. It's actually
possible to avoid it nowadays, if you use the right APIs, but not all programs
amccarth added a comment.
Thanks for doing this. This seems a reasonable alternative to fixing all the
build tools upstream. And overly long paths are difficult to read.
https://reviews.llvm.org/D34553
___
lldb-commits mailing list
lldb-commits@l
vsk added a comment.
Thanks, this lgtm. Our tools don't depend on these plugins having a particular
file name.
https://reviews.llvm.org/D34553
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306134: Fix typo: using && instead of & when evaluating a
mask (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D34550?vs=103690&id=103752#toc
Repository:
rL LLVM
https:/
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
I try to avoid making cryptic file names just to get them under some character
count, since that also makes code hard to comprehend particularly for new
users. But in this case everybody ca
Author: spyffe
Date: Fri Jun 23 18:15:03 2017
New Revision: 306180
URL: http://llvm.org/viewvc/llvm-project?rev=306180&view=rev
Log:
Updated the NSArray and NSDictionary formatters to support new storage formats.
Also un-xfailed a testcase that was affected by this. Thanks to Jason Molenda
for
Author: zturner
Date: Fri Jun 23 18:55:32 2017
New Revision: 306186
URL: http://llvm.org/viewvc/llvm-project?rev=306186&view=rev
Log:
Fix LLDB build.
This was broken due to directly including windows.h, which
caused a problem when someone in LLVM called std::min in a header
file. LLDB has a wind
krytarowski added a comment.
Looks good. It's easier to parse [at least for my eyes]: ubsan, asan, tsan etc
than full-names.
https://reviews.llvm.org/D34553
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
11 matches
Mail list logo
