ravitheja updated this revision to Diff 103355.
ravitheja added a comment.
Changes for last feedback.
https://reviews.llvm.org/D33674
Files:
include/lldb/Host/common/NativeProcessProtocol.h
include/lldb/Host/linux/Support.h
source/Host/linux/Support.cpp
source/Plugins/Process/Linux/CMak
labath added a comment.
I like the direction this is going in, but I see places for more cleanup. The
main three items are:
- making destruction cleaner
- avoiding global variables
- making ReadCyclicBuffer readable
the rest are just general nits.
Comment at: source/Plugins/
