[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

2017-06-18 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added a comment. I see. The approach to escape as little as possible can be valid, I guess. In any case, this patch seems to do exactly this. We must escape backslashes, otherwise we’ll produce invalid output: imagine a backslash at the end of the string. Same about newlines: ther

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

2017-06-18 Thread Joerg Sonnenberger via Phabricator via lldb-commits
joerg added a comment. My suggestion would be to just use the YAML writer for now and leave a comment to make it clear that this is really JSON only. https://reviews.llvm.org/D34322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [lldb] r305664 - Fix a -Wmisleading-indentation warning

2017-06-18 Thread Sylvestre Ledru via lldb-commits
Author: sylvestre Date: Mon Jun 19 01:57:54 2017 New Revision: 305664 URL: http://llvm.org/viewvc/llvm-project?rev=305664&view=rev Log: Fix a -Wmisleading-indentation warning Modified: lldb/trunk/source/Commands/CommandObjectFrame.cpp Modified: lldb/trunk/source/Commands/CommandObjectFrame.