[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:611 + +if (ProcessorTraceMonitor::GetProcessTraceID() != LLDB_INVALID_UID) { + auto traceMonitor = ProcessorTraceMonitor::Create( labath wrote: > Every call

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added inline comments. Comment at: source/Plugins/Process/Linux/ProcessorTrace.cpp:158 +LLDB_LOG(log, "ProcessorTrace failed to open Config file"); +error.SetError(FileNotFound, eErrorTypePOSIX); +return error; labath wrote: > eErrorTypePOSI

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

labath added a comment. Unfortunately, posix_spawn does not satisfy all our needs for launching processes on non-darwin platforms (according to its design rationale, that was never the intention). The most notable one is the "launch a process for debugging". Darwin seems to have added extension

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:282 + // same process user id. + llvm::DenseSet m_pt_traced_thread_group; }; ravitheja wrote: > labath wrote: > > I am confused about the purpose of this member variabl

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

labath created this revision. Use c++11 thread_local variables instead. As far as I am aware, they are supported by all compilers/targets we care about. https://reviews.llvm.org/D34274 Files: include/lldb/Host/Host.h source/Core/Timer.cpp source/Host/common/Host.cpp source/Host/windows/

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added a comment. Just to make things clear, I will explain a use case Suppose if we are debugging an application where the main thread spawns a second new thread -> int main() { int i = 0; // user starts tracing on main thread -> gets traceid 1 . // Some statements i++;

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:282 + // same process user id. + llvm::DenseSet m_pt_traced_thread_group; }; labath wrote: > ravitheja wrote: > > labath wrote: > > > I am confused about the purpose

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added inline comments. Comment at: source/Plugins/Process/Linux/ProcessorTrace.cpp:158 +LLDB_LOG(log, "ProcessorTrace failed to open Config file"); +error.SetError(FileNotFound, eErrorTypePOSIX); +return error; labath wrote: > ravitheja wrot

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

zturner added a comment. The last time I tried to do this we couldn't because it didn't yet work on iOS. I checked with some Apple people though and they said `thread_local` support was released last year on all Apple platforms. So hopefully there's no more hurdles to getting this in. https

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

krytarowski added a comment. Modern BSDs should be fine on popular platforms. https://reviews.llvm.org/D34274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r305589 - Upstreaming the UndefinedBehaviorSanitizerRuntime and MainThreadCheckerRuntime plugins.

Author: kuba.brecka Date: Fri Jun 16 15:59:08 2017 New Revision: 305589 URL: http://llvm.org/viewvc/llvm-project?rev=305589&view=rev Log: Upstreaming the UndefinedBehaviorSanitizerRuntime and MainThreadCheckerRuntime plugins. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/

[Lldb-commits] [lldb] r305594 - Fix the CMake files for the new InstrumentationRuntime plugins.

Author: kuba.brecka Date: Fri Jun 16 16:18:28 2017 New Revision: 305594 URL: http://llvm.org/viewvc/llvm-project?rev=305594&view=rev Log: Fix the CMake files for the new InstrumentationRuntime plugins. Modified: lldb/trunk/source/Plugins/InstrumentationRuntime/MainThreadChecker/CMakeLists.t

[Lldb-commits] Buildbot numbers for the week of 05/28/2017 - 06/03/2017

Hello everyone, Below are some buildbot numbers for the week of 05/28/2017 - 06/03/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[Lldb-commits] Buildbot numbers for the week of 06/04/2017 - 06/10/2017

Hello everyone, Below are some buildbot numbers for the last week of 06/04/2017 - 06/10/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

emaste added a comment. Fine from FreeBSD https://reviews.llvm.org/D34274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

emaste added a comment. FreeBSD build and test in progress. https://reviews.llvm.org/D34236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits