[Lldb-commits] [lldb] r305461 - [swig] Improve the native module import logic

Author: labath Date: Thu Jun 15 06:23:22 2017 New Revision: 305461 URL: http://llvm.org/viewvc/llvm-project?rev=305461&view=rev Log: [swig] Improve the native module import logic The simple module import logic was not sufficient for our distribution model of lldb, which is without the _lldb.pyd f

[Lldb-commits] [lldb] r305462 - Add llvm::Error assignment operator to Status class

Author: labath Date: Thu Jun 15 06:23:26 2017 New Revision: 305462 URL: http://llvm.org/viewvc/llvm-project?rev=305462&view=rev Log: Add llvm::Error assignment operator to Status class This enables writing "status = std::move(some_llvm_error)". Modified: lldb/trunk/include/lldb/Utility/Statu

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

labath added a comment. Second round of comments. I still see a lot of places with redundant checks for what appear to be operational invariants. I'd like to get those cleared up to make the code flow better. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:611

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

labath created this revision. Herald added subscribers: mgorny, srhines. ProcessLauncherPosix was using posix_spawn for launching the process, but this function is not available on all platforms we support, and even where it was avaialable, it did not support the full range of options we require f

[Lldb-commits] [PATCH] D34199: Tweak SysV_arm64 function entry unwind plan

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good https://reviews.llvm.org/D34199 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. NetBSD part looks good. In next step we can rename ProcessLauncherPosixFork to ProcessLauncherPosix. https://reviews.llvm.org/D34236 _

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

rnk added a comment. `posix_spawn` is considered the preferred, efficient, canonical way to launch processes on Mac. Are you sure you want to remove support for it? https://reviews.llvm.org/D34236 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

jingham added a comment. This patch doesn't remove support for posix_spawn on OS X - it is moving to the macOS Host.mm. Kind of sad as posix_spawn was supposed to remove a lot of the platform-dependent and error-prone parts of process launching from the system. But you have to live with what

[Lldb-commits] [PATCH] D34199: Tweak SysV_arm64 function entry unwind plan

jasonmolenda accepted this revision. jasonmolenda added a comment. Looks good to me. https://reviews.llvm.org/D34199 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D34199: Tweak SysV_arm64 function entry unwind plan

omjavaid accepted this revision. omjavaid added a comment. LGTM https://reviews.llvm.org/D34199 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r305547 - Change the code I added to LocateDSYMInVincinityOfExecutable to use

Author: jmolenda Date: Thu Jun 15 23:19:36 2017 New Revision: 305547 URL: http://llvm.org/viewvc/llvm-project?rev=305547&view=rev Log: Change the code I added to LocateDSYMInVincinityOfExecutable to use the FileSpec methods for adding/removing file path components instead of using std::strings; fe