krytarowski added a comment.
NetBSD part looks fine.
https://reviews.llvm.org/D33998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Thanks for the review. I'm not entirely proud of how I implemented this, but I
hope it's not too ugly either. The reason I opted for this approach is that I
needed to implement the "if the module is null then decrement the address and
recompute" logic in two places. Regi
Author: labath
Date: Thu Jun 8 08:26:35 2017
New Revision: 304976
URL: http://llvm.org/viewvc/llvm-project?rev=304976&view=rev
Log:
Fix backtrace of noreturn functions situated at the end of a module
Summary:
When a call instruction is the last instruction in a function, the
backtrace PC will po
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304976: Fix backtrace of noreturn functions situated at the
end of a module (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32022?vs=101555&id=101900#toc
Repository:
rL LLVM
eugene added inline comments.
Comment at: source/Host/common/Host.cpp:1010
+static constexpr char type[] = "WXS";
+OS << formatv("{0}{1:x-2}", type[WS.type], WS.status);
+return;
type[WS.type] seems to be a somewhat unnecessary hack. I would use a si
Author: davide
Date: Thu Jun 8 18:49:56 2017
New Revision: 305035
URL: http://llvm.org/viewvc/llvm-project?rev=305035&view=rev
Log:
[VMRange] Simplify a couple of member functions. NFCI.
Modified:
lldb/trunk/source/Utility/VMRange.cpp
Modified: lldb/trunk/source/Utility/VMRange.cpp
URL:
ht
Note that even simpler would be
```
return llvm::find_if(col, in_range_predicate) != col.end();
```
On Thu, Jun 8, 2017 at 4:50 PM Davide Italiano via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: davide
> Date: Thu Jun 8 18:49:56 2017
> New Revision: 305035
>
> URL: http://llvm.
Fair enough. I'll make this change and run the testsuite again.
I've been a little scared of pushing NFCI changes in lldb as the
testsuite doesn't seem to be consistently "green" (even without
modifications), but I'll try this one.
Thanks Zachary!
--
Davide
On Thu, Jun 8, 2017 at 4:55 PM, Zachar
