[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

labath added a comment. Cool. Sorry about all the back-and-forth and thanks for the patience. https://reviews.llvm.org/D33426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

On 6 June 2017 at 18:41, Jim Ingham wrote: > This is WWDC week. We’ll try to find time to take a look at this, but > silence may mean preoccupation more than anything else… > I was not trying to imply it means anything else than that. However, after two months of inactivity, I was running out o

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:156 + // - + static size_t ReadCyclicBuffer(void *buf, size_t buf_size, void *cyc_buf, +

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3009-3010 + errno = 0; + m_mmap_base = + mmap(NULL, (metabufsize + page_size), PROT_WRITE, MAP_SHARED, m_fd, 0); + if (m_mmap_base == MAP_FAILED) { zturner wr

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:156 + // - + static size_t ReadCyclicBuffer(void *buf, size_t buf_size, void *cyc_buf, +

[Lldb-commits] [lldb] r304924 - Switch TaskMapOverInt to llvm::function_ref

Author: labath Date: Wed Jun 7 11:28:08 2017 New Revision: 304924 URL: http://llvm.org/viewvc/llvm-project?rev=304924&view=rev Log: Switch TaskMapOverInt to llvm::function_ref The function does not persist the callback, so using a lighter-weight asbtraction seems appropriate. Also tweak the sig

[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

labath created this revision. Herald added a subscriber: mgorny. A number of places were trying to decode the result of wait(). Add a simple utility function that does that and a struct that encapsulates the decoded result. Then also provide a pretty-printer for that class. https://reviews.llvm.

[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

labath updated this revision to Diff 101759. labath added a comment. Fix typo https://reviews.llvm.org/D33998 Files: include/lldb/Host/Host.h include/lldb/Host/common/NativeProcessProtocol.h include/lldb/lldb-private-enumerations.h source/Host/common/Host.cpp source/Host/common/Native

[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

krytarowski added inline comments. Comment at: source/Host/common/Host.cpp:1001 +return {Stop, uint8_t(WSTOPSIG(wstatus))}; + llvm_unreachable("Unknown wait status"); +} `WIFCONTINUED()`? https://reviews.llvm.org/D33998 _

[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

labath added inline comments. Comment at: source/Host/common/Host.cpp:1001 +return {Stop, uint8_t(WSTOPSIG(wstatus))}; + llvm_unreachable("Unknown wait status"); +} krytarowski wrote: > `WIFCONTINUED()`? I'm deliberately ignoring that, as we don't have a use

[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

krytarowski added inline comments. Comment at: source/Host/common/Host.cpp:1001 +return {Stop, uint8_t(WSTOPSIG(wstatus))}; + llvm_unreachable("Unknown wait status"); +} labath wrote: > krytarowski wrote: > > `WIFCONTINUED()`? > I'm deliberately ignoring tha

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. https://reviews.llvm.org/D33426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Pavel, my apologies for not following up on this, we had a big push to get ready for a beta release/conference this week, but it wasn't fair to leave you hanging with this change.