Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

2017-06-06 Thread Pavel Labath via lldb-commits
I think the discussion has veered of from the "lldb-server testing" topic into the more murky "general testing" waters. I'll put my thoughts on those first, and then get back to lldb-server test plans. On 31 May 2017 at 18:37, Zachary Turner via Phabricator wrote: > What *would* help would be to

[Lldb-commits] [lldb] r304793 - New framework for lldb client-server communication tests.

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 08:40:18 2017 New Revision: 304793 URL: http://llvm.org/viewvc/llvm-project?rev=304793&view=rev Log: New framework for lldb client-server communication tests. Summary: This is a new C++ test framework based on Google Test, and one working example test. The intentio

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

2017-06-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I am going to commit this, so we can move forward with the remote testing aspect. I'd like to reiterate that we are not planning to remove any existing tests until both remote and debugserver testing work. At that point, we'd like to start removing the existing tests, b

[Lldb-commits] [lldb] r304794 - Remove unused variables. NFC

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 08:40:21 2017 New Revision: 304794 URL: http://llvm.org/viewvc/llvm-project?rev=304794&view=rev Log: Remove unused variables. NFC Modified: lldb/trunk/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp Modified: lldb/trunk/unittests/Process/gdb

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

2017-06-06 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304793: New framework for lldb client-server communication tests. (authored by labath). Changed prior to commit: https://reviews.llvm.org/D32930?vs=100288&id=101553#toc Repository: rL LLVM https://r

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

2017-06-06 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 101555. labath added a comment. Herald added a subscriber: srhines. Add documentation. https://reviews.llvm.org/D32022 Files: include/lldb/Core/Address.h include/lldb/Core/Section.h include/lldb/Target/SectionLoadList.h packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

2017-06-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I'd like to commit this this week. If you have any objections to how I implemented this, let me know, so I can adjust the approach. https://reviews.llvm.org/D32022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] r304795 - replace uses of strerror with llvm::sys::StrError

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 09:06:17 2017 New Revision: 304795 URL: http://llvm.org/viewvc/llvm-project?rev=304795&view=rev Log: replace uses of strerror with llvm::sys::StrError strerror is not thread-safe. llvm's StrError tries hard to retrieve the string in a thread-safe way and falls back

[Lldb-commits] [lldb] r304796 - Fix assorted compiler warnings. NFC

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 09:06:22 2017 New Revision: 304796 URL: http://llvm.org/viewvc/llvm-project?rev=304796&view=rev Log: Fix assorted compiler warnings. NFC Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp lldb/trunk/source/Plug

Re: [Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

2017-06-06 Thread Jim Ingham via lldb-commits
This is WWDC week. We’ll try to find time to take a look at this, but silence may mean preoccupation more than anything else… Jim > On Jun 6, 2017, at 6:53 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I'd like to commit this this week. If you have any objections

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

2017-06-06 Thread Brian Gianforcaro via Phabricator via lldb-commits
bgianfo updated this revision to Diff 101664. bgianfo added a comment. Update test to user thread.StepOut() instead of thread.Resume(). https://reviews.llvm.org/D33426 Files: include/lldb/Core/Debugger.h include/lldb/Target/StackFrame.h include/lldb/Target/StackFrameList.h include/lldb/

[Lldb-commits] [lldb] r304864 - Move Object format code to lib/BinaryFormat.

2017-06-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Jun 6 22:48:56 2017 New Revision: 304864 URL: http://llvm.org/viewvc/llvm-project?rev=304864&view=rev Log: Move Object format code to lib/BinaryFormat. This creates a new library called BinaryFormat that has all of the headers from llvm/Support containing structure and