labath added a comment.
Don't forget to update the usages in unit tests (and make sure the
check-lldb-unit target passes).
Seems reasonable, however: I am not sure who actually uses these timers. I'd be
tempted to just remove the timers that are causing the contention.
Comme
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Perfect, thank you.
Do you have commit access?
https://reviews.llvm.org/D32421
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
labath added a comment.
I have feeling you gave up on the llvm change too quickly. My interpretation of
that thread was that there was general support for the hash function switch,
and people only wanted some confirmation it will not regress.
However, I do believe that this can be made faster t
Author: labath
Date: Thu May 4 05:11:33 2017
New Revision: 302133
URL: http://llvm.org/viewvc/llvm-project?rev=302133&view=rev
Log:
MainLoop: Add unit tests
Summary:
This adds a couple of unit tests to the MainLoop class. To get the
kqueue based version of the signal handling passing, I needed t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302133: MainLoop: Add unit tests (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32753?vs=97464&id=97802#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32753
Files:
lld
Author: nitesh.jain
Date: Thu May 4 06:34:42 2017
New Revision: 302139
URL: http://llvm.org/viewvc/llvm-project?rev=302139&view=rev
Log:
[LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.
Reviewers: jingham, labath
Subscribers: jaydeep, bhushan, lldb-commits, slthakur
Differential Revision: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302139: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.
(authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D32168?vs=97415&id=97811#toc
Repository:
rL LLVM
https://revi
tberghammer added a comment.
I am a bit confused by the correlation between your change and commit message.
In the commit message you say that 32 byte structs are passed as x8 pointers
but the implementation of LoadValueFromConsecutiveGPRRegisters seems to read it
out from the v0-v8 registers f
labath added a comment.
In https://reviews.llvm.org/D32813#746012, @tberghammer wrote:
> I am a bit confused by the correlation between your change and commit
> message. In the commit message you say that 32 byte structs
I mean 32-byte vectors. I.e. variables declared as `float foo
__attribut
jroelofs created this revision.
Herald added a subscriber: mgorny.
There are two issues here. The first:
liblldbHost.a(Editline.cpp.o):(.debug_addr+0x238): undefined reference to
`el_get'
when linking InterpreterTests, is caused by -ledit coming after liblldbHost.a
in the link line.
The sec
krytarowski added a comment.
NetBSD change looks fine.
https://reviews.llvm.org/D32866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jroelofs planned changes to this revision.
jroelofs added a comment.
hmm. I'm getting more libpanel link issues in another build.
https://reviews.llvm.org/D32866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
krytarowski added a comment.
FYI, NetBSD has its distinct libpanel in its base system, API compatible with
ncurses.
https://reviews.llvm.org/D32866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
jroelofs updated this revision to Diff 97842.
https://reviews.llvm.org/D32866
Files:
source/Core/CMakeLists.txt
source/Host/CMakeLists.txt
Index: source/Host/CMakeLists.txt
===
--- source/Host/CMakeLists.txt
+++ source/Host/CMa
xiaobai added a comment.
I do not have commit access. I would appreciate it if you could commit it for
me.
https://reviews.llvm.org/D32421
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
jingham added a comment.
Yes, I was printing a global variable that WASN'T defined in the source file I
later stopped in. So it worked for me. The bug is really that looking up a
variable by name goes through and adds only that variable to the CU that
defines it, but the CU doesn't make note
scott.smith marked 3 inline comments as done.
scott.smith added a comment.
In https://reviews.llvm.org/D32823#745799, @labath wrote:
> Seems reasonable, however: I am not sure who actually uses these timers. I'd
> be tempted to just remove the timers that are causing the contention.
IMO we sho
I'd vote for keeping the timers if possible. Their job is to tell you "of the
time spent in some operation, how much was spent in say DWARF parsing", etc.
That has been useful on occasion.
Jim
> On May 4, 2017, at 2:12 PM, Scott Smith via Phabricator via lldb-commits
> wrote:
>
> scott.smi
scott.smith updated this revision to Diff 97880.
scott.smith marked an inline comment as done.
scott.smith added a comment.
updated per review comments.
added a test to fix the Jurassic Park problem.
Repository:
rL LLVM
https://reviews.llvm.org/D32823
Files:
include/lldb/Core/Timer.h
sou
scott.smith added a comment.
In https://reviews.llvm.org/D32757#743793, @zturner wrote:
> Not to sound like a broken record, but please try to put this in LLVM instead
> of LLVM. I suggested a convenient function signature earlier.
@zturner ok to commit? TaskMapOverInt(x, y, fn) maps directl
scott.smith updated this revision to Diff 97907.
scott.smith added a comment.
1. Change the API to more closely match parallel_for (begin, end, fn) instead
of (end, batch, fn).
2. Fix unit test. I didn't realize I had to run check-lldb-unit separately
from dotest (oops).
3. Fix formatting via g
scott.smith added a comment.
Last changes are cosmetic (though look big because I captured a different
amount of context) so hopefully doesn't need a re-review. Can someone push
them for me? Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D32757
scott.smith added a subscriber: ruiu.
scott.smith added inline comments.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:530-560
+ struct loader {
+DYLDRendezvous::iterator I;
+ModuleSP m;
+std::shared_future f;
+ };
+ std::vector lo
23 matches
Mail list logo
