vbalu created this revision.
Adding test case to test the scenario in https://reviews.llvm.org/D3
Repository:
rL LLVM
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
packages/Python/lldbsuite/test/lldbtest.py
In
ravitheja updated this revision to Diff 96682.
ravitheja added a comment.
Fixing few header file inclusions.
https://reviews.llvm.org/D29581
Files:
include/lldb/API/LLDB.h
include/lldb/API/SBDefines.h
include/lldb/API/SBError.h
include/lldb/API/SBProcess.h
include/lldb/API/SBStructure
Author: ravitheja
Date: Wed Apr 26 03:48:50 2017
New Revision: 301389
URL: http://llvm.org/viewvc/llvm-project?rev=301389&view=rev
Log:
Initial implementation of SB APIs for Tracing support.
Summary:
This patch introduces new SB APIs for tracing support
inside LLDB. The idea is to gather trace da
labath added a comment.
Thank you for taking the time to add the test.
I'd like to avoid modifying the test framework for the sake of this test, if
that is possible.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1487
'EXE': exe_name}
+if not os.
labath requested review of this revision.
labath added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D32434#737205, @labath wrote:
> In https://reviews.llvm.org/D32434#737179, @zturner wrote:
>
> > If you look at the source code of yaml2obj, all this boil
tberghammer added a comment.
I looked into the history of this code once and my understanding is that Enrico
added this code in
https://github.com/llvm-mirror/lldb/commit/bad9753828b6e0e415e38094bb9627e41d57874c
but it have never been used (at least in upstream). The original commit
message al
nitesh.jain updated this revision to Diff 96722.
nitesh.jain added a comment.
Update diff as per suggestion
https://reviews.llvm.org/D32168
Files:
include/lldb/API/SBAddress.h
include/lldb/API/SBInstructionList.h
packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpo
scott.smith added a comment.
In https://reviews.llvm.org/D32503#737953, @tberghammer wrote:
> I looked into the history of this code once and my understanding is that
> Enrico added this code in
> https://github.com/llvm-mirror/lldb/commit/bad9753828b6e0e415e38094bb9627e41d57874c
> but it have
tberghammer added a comment.
I am fully support deleting it (and pretty much any unused code). If we need it
in the future then we will still have it in the svn history.
Repository:
rL LLVM
https://reviews.llvm.org/D32503
___
lldb-commits mailin
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Code is still present in history, if someone needs this again in the future
they can do some git archaeology to dig it up.
Repository:
rL LLVM
https://reviews.llvm.org/D32503
krytarowski added a comment.
ping?
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
scott.smith added a comment.
In https://reviews.llvm.org/D32503#738243, @zturner wrote:
> Code is still present in history, if someone needs this again in the future
> they can do some git archaeology to dig it up.
Can someone please commit this for me? I don't have access. Thank you!
Repo
zturner accepted this revision.
zturner added a comment.
Alright, thanks for trying anyway!
https://reviews.llvm.org/D32434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
scott.smith added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
zturner wrote:
> Why do
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The substance seems fine.
I'm not sure I would guess what GetInstructionsCount with canSetBreakpoint ==
true would do without reading the code. You could fix this with a more
exp
Other alternatives though include adding a function to StringMap which
gives us what we need, and having this function do the pointer hacking, or
simply calling strlen.
On Wed, Apr 26, 2017 at 11:03 AM Scott Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> scott.smith added inline comme
Author: lhames
Date: Wed Apr 26 13:15:40 2017
New Revision: 301441
URL: http://llvm.org/viewvc/llvm-project?rev=301441&view=rev
Log:
Use llvm::ArrayRef rather than std::vector/std::initializer lists for some
ValueObject methods.
Using ArrayRef allows us to remove some overloads, work with more ar
Author: spyffe
Date: Wed Apr 26 15:36:47 2017
New Revision: 301461
URL: http://llvm.org/viewvc/llvm-project?rev=301461&view=rev
Log:
Fixed a crash when dealing with an empty method name in the ObjC runtime.
I've filed a bug covering better unit testing of our runtime metadata reader,
which will a
Author: rsmith
Date: Wed Apr 26 17:10:53 2017
New Revision: 301483
URL: http://llvm.org/viewvc/llvm-project?rev=301483&view=rev
Log:
Update lldb to match clang r301442.
This code really doesn't make any sense: there is only ever one InputKind here.
Plus, this is an incomplete and out-of-date copy
scott.smith created this revision.
Both routines (on Linux, at least) utilize a cache; protect the cache with a
mutex to allow concurrent callers.
Repository:
rL LLVM
https://reviews.llvm.org/D32568
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/
scott.smith updated this revision to Diff 96841.
scott.smith added a comment.
Use StringMapEntry::GetStringMapEntryFromKeyData instead of ConstString's
version.
Repository:
rL LLVM
https://reviews.llvm.org/D32306
Files:
source/Utility/ConstString.cpp
Index: source/Utility/ConstString.cp
Author: cbieneman
Date: Wed Apr 26 18:17:20 2017
New Revision: 301492
URL: http://llvm.org/viewvc/llvm-project?rev=301492&view=rev
Log:
Re-landing IPv6 support for LLDB Host
This support was landed in r300579, and reverted in r300669 due to failures on
the bots.
The failures were caused by sock
Author: lhames
Date: Wed Apr 26 18:29:59 2017
New Revision: 301493
URL: http://llvm.org/viewvc/llvm-project?rev=301493&view=rev
Log:
Fix libcxx formatters for changes in r300140.
Summary:
LLVM r300140 changed the layout and field names of __compressed_pair, which
broke LLDB's std::vector, std::ma
Author: cbieneman
Date: Wed Apr 26 19:03:27 2017
New Revision: 301502
URL: http://llvm.org/viewvc/llvm-project?rev=301502&view=rev
Log:
Fix Windows bots broken by r301492
http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015/builds/8644/
Modified:
lldb/trunk/source/Host/common/TCPSocke
Author: cbieneman
Date: Wed Apr 26 19:23:41 2017
New Revision: 301504
URL: http://llvm.org/viewvc/llvm-project?rev=301504&view=rev
Log:
One more attempt to fix the broken bots.
Modified:
lldb/trunk/source/Host/common/TCPSocket.cpp
Modified: lldb/trunk/source/Host/common/TCPSocket.cpp
URL:
h
Author: cbieneman
Date: Wed Apr 26 19:47:19 2017
New Revision: 301506
URL: http://llvm.org/viewvc/llvm-project?rev=301506&view=rev
Log:
One more try at the whole compiling thing...
Need to actually use the right type in both parts of the cast.
Modified:
lldb/trunk/source/Host/common/TCPSocke
26 matches
Mail list logo
