[Lldb-commits] [PATCH] D31877: Remove Plugins/Process/POSIX from include_directories

2017-04-10 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a subscriber: mgorny. The files there can always be referred to using their full path, which is what most of the code has been doing already, so this makes the situation more consistent. Also fix the the code in the FreeBSD plugin to use the new paths.

[Lldb-commits] [PATCH] D31357: Support Unit Testing debugserver

2017-04-10 Thread Chris Bieneman via Phabricator via lldb-commits
beanz updated this revision to Diff 94526. beanz added a comment. Fixing variable naming conventions https://reviews.llvm.org/D31357 Files: tools/debugserver/source/CMakeLists.txt tools/debugserver/source/MacOSX/CMakeLists.txt unittests/CMakeLists.txt unittests/debugserver/CMakeLists.tx

[Lldb-commits] [PATCH] D31822: [NFC] Adding a new wrapper for getaddrinfo

2017-04-10 Thread Chris Bieneman via Phabricator via lldb-commits
beanz created this revision. This patch adds a new wrapper for getaddrinfo which returns a std::vector of SocketAddresses. While this patch doesn't add any uses of the new function, I have two separable patches that are dependent on this, so I put it in its own patch. https://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D31877: Remove Plugins/Process/POSIX from include_directories

2017-04-10 Thread Zachary Turner via lldb-commits
Lgtm On Mon, Apr 10, 2017 at 11:03 AM Pavel Labath via Phabricator via lldb-commits wrote: > labath created this revision. > Herald added a subscriber: mgorny. > > The files there can always be referred to using their full path, which > is what most of the code has been doing already, so this mak

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Hmm still wrong. Later in this code: // NetBSD per-thread information is stored in notes named // "NetBSD-CORE@nnn" so match on the initial part of the string. m_os = llvm::Triple::NetBSD; if (note.n_type == NETBSD::NT_PROCINFO) { ParseNetBSDProcInfo(*thr

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Other BSDs work. Repository: rL LLVM https://reviews.llvm.org/D31825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31880: Fix libc++ vector data formatter (bug #32553)

2017-04-10 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a reviewer: EricWF. The iteration list through the available data formatters was undefined, which meant that the vector formatter kicked in only in cases where it happened to be queried before the general vector formatter. To fix this, I merge the two dat

[Lldb-commits] [PATCH] D31882: Fix the libc++ std::vector data formatter

2017-04-10 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer created this revision. Herald added a reviewer: EricWF. Fix the libc++ std::vector data formatter Previously we randomly triggered either the std::vector<...> or the std::vector data formatter causing an issue when the former got triggered for an std::vector. This change moves the lo

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. For the reference, I uploaded FreeBSD/amd64 and OpenBSD/i386 core(5) files: http://netbsd.org/~kamil/lldb/freebsd.10.3.release.p11-top.core.93102 http://netbsd.org/~kamil/lldb/openbsd.6.0-top.core Repository: rL LLVM https://reviews.llvm.org/D31825 ___

[Lldb-commits] [PATCH] D31880: Fix libc++ vector data formatter (bug #32553)

2017-04-10 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added a comment. The previous version of the data formatter was triggering for std::vector> as well. Jason, do you know why was it the case? Do we need that functionality because of a broken compiler version or can it be removed? Note: I added a few comments about the data formatte

[Lldb-commits] [PATCH] D31882: Fix the libc++ std::vector data formatter

2017-04-10 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer abandoned this revision. tberghammer added a comment. Pavel created a separate fix as https://reviews.llvm.org/D31880. Abandoning this one. https://reviews.llvm.org/D31882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D31880: Fix libc++ vector data formatter (bug #32553)

2017-04-10 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 94667. labath added a comment. Remove the vector summary provider as well (picked up from Tamas's version of the patch). https://reviews.llvm.org/D31880 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/

[Lldb-commits] [PATCH] D31877: Remove Plugins/Process/POSIX from include_directories

2017-04-10 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene accepted this revision. eugene added a comment. This revision is now accepted and ready to land. Thanks for doing it. IMO we should always strive to use "absolute" path for all headers. https://reviews.llvm.org/D31877 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D31877: Remove Plugins/Process/POSIX from include_directories

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Thank you for working on it! https://reviews.llvm.org/D31877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

2017-04-10 Thread Chris Bieneman via Phabricator via lldb-commits
beanz created this revision. Herald added a subscriber: emaste. This patch adds IPv6 support to LLDB/Host's TCP socket implementation. Supporting IPv6 involved a few significant changes to the implementation of the socket layers, and I have performed some significant code cleanup along the way.

[Lldb-commits] [PATCH] D31824: Update DebugServer to support IPv6 over TCP

2017-04-10 Thread Chris Bieneman via Phabricator via lldb-commits
beanz created this revision. Herald added a subscriber: mgorny. This patch adds IPv6 support to debugserver. It follows a similar pattern to the changes proposed for LLDB/Host except that the listen implementation is only with kqueue(2) because debugserver is only supported on Darwin. https://

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski created this revision. krytarowski added a project: LLDB. This change has been authored by Zachary Turner. It fixes loading into the debugger core(5) files generated by NetBSD x86_64 v. 7.99.67. These core(5) files have the e_ident[EI_OSABI] property set to ELFOSABI_SYSV. It might ch

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Example core(5) file: http://netbsd.org/~kamil/lldb/top.core Generated with gcore(1), which snapshoted a running top(1) program. Repository: rL LLVM https://reviews.llvm.org/D31825 ___ lldb-commits mailing list lldb-

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-04-10 Thread Geoff Berry via lldb-commits
Hans, Sorry for the confusion, but this isn't the change I was referring to. I included the phabricator review numbers in my original message, not svn commit numbers. On 2/3/2017 4:54 PM, Hans Wennborg wrote: Geoff asked for this to be merged to 4.0. It looks like a nice change, but I'm a

[Lldb-commits] [lldb] r299898 - Update for alloca construction changes

2017-04-10 Thread Matt Arsenault via lldb-commits
Author: arsenm Date: Mon Apr 10 18:27:53 2017 New Revision: 299898 URL: http://llvm.org/viewvc/llvm-project?rev=299898&view=rev Log: Update for alloca construction changes Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp Modif

[Lldb-commits] [lldb] r299845 - [lldb] Fix ninja URL

2017-04-10 Thread Shoaib Meenai via lldb-commits
Author: smeenai Date: Mon Apr 10 10:41:15 2017 New Revision: 299845 URL: http://llvm.org/viewvc/llvm-project?rev=299845&view=rev Log: [lldb] Fix ninja URL The old URL is a 404 now. Pointed out by Smirftsch1 on IRC. Modified: lldb/trunk/www/build.html Modified: lldb/trunk/www/build.html URL:

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-04-10 Thread Tim Hammerquist via lldb-commits
Hi Zachary! Thank you for your prompt attention! I notice you added DumpHexBytes() back, but Dump() is still missing. Was Dump() slated for a later patch? -Tim > On 3 Mar 2017, at 15:48, Zachary Turner wrote: > > Yea, it was a static method of DataExtractor before. I noticed the same > thi

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-04-10 Thread Tim Hammerquist via lldb-commits
Sure, Zachary. I try to step in when I can. Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB team on how they want to foll