[Lldb-commits] [PATCH] D30981: Remove HostThreadLinux/Free/NetBSD

2017-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D30981#701902, @krytarowski wrote: > Currently these calls for set/get thread name were moved to LLVM. I haven't > checked other systems but the NetBSD one must be called for the current > process. > > The original NetBSD version was ported fr

[Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

2017-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added subscribers: mgorny, srhines. GetAuxvData was causing dependencies from host to target and linux process modules. It also does not fit netbsd use case, as there we can only read the auxiliary vector with ptrace, which is better done in the process plugin,

[Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

2017-03-16 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. You mention that this was the cause of dependencies from `Host` to `Target`, but I don't see any `#include "lldb/Target/*.h"` statements removed. Is this an oversight or not possible yet? https://reviews.llvm.org/D31031 _

[Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

2017-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D31031#702747, @zturner wrote: > You mention that this was the cause of dependencies from `Host` to `Target`, > but I don't see any `#include "lldb/Target/*.h"` statements removed. Is this > an oversight or not possible yet? I guess I wasn'

Re: [Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

2017-03-16 Thread Zachary Turner via lldb-commits
It's fine, just checking :) lgtm On Thu, Mar 16, 2017 at 7:49 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > In https://reviews.llvm.org/D31031#702747, @zturner wrote: > > > You mention that this was the cause of dependencies from `Host` to > `Ta

[Lldb-commits] [PATCH] D30981: Remove HostThreadLinux/Free/NetBSD

2017-03-16 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Thank you for your explanation. I will use approach similar to FreeBSD on NetBSD. I agree that leaving the FreeBSD code is best for the maintainers - it's good enough. https://rev

[Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

2017-03-16 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Thank you for this. https://reviews.llvm.org/D31031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D30981: Remove HostThreadLinux/Free/NetBSD

2017-03-16 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/thread-name/main.cpp:6 +#if defined(__linux__) || defined(__NetBSD__) + ::pthread_setname_np(::pthread_self(), name); +#elif defined(__FreeBSD__) I overlooked it. `

[Lldb-commits] [lldb] r298004 - [Support] Support both Windows and Posix paths on both platforms.

2017-03-16 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Mar 16 17:28:04 2017 New Revision: 298004 URL: http://llvm.org/viewvc/llvm-project?rev=298004&view=rev Log: [Support] Support both Windows and Posix paths on both platforms. Previously which path syntax we supported dependend on what platform we were compiling LLVM on.

[Lldb-commits] [lldb] r298011 - Update for LLVM API removal of Function::getArgumentList()

2017-03-16 Thread Reid Kleckner via lldb-commits
Author: rnk Date: Thu Mar 16 18:13:49 2017 New Revision: 298011 URL: http://llvm.org/viewvc/llvm-project?rev=298011&view=rev Log: Update for LLVM API removal of Function::getArgumentList() Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp lldb/trunk/source/Plugin

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module.

2017-03-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good, sorry for the delay. https://reviews.llvm.org/D30454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.