labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great. Thank you.
https://reviews.llvm.org/D30286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: labath
Date: Fri Feb 24 03:29:14 2017
New Revision: 296101
URL: http://llvm.org/viewvc/llvm-project?rev=296101&view=rev
Log:
Implement QPassSignals GDB package in lldb-server
Summary: QPassSignals package allows lldb client to tell lldb-server to ignore
certain types of signals and re-in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296101: Implement QPassSignals GDB package in lldb-server
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30286?vs=89575&id=89623#toc
Repository:
rL LLVM
https://reviews.llv
labath added a comment.
I am not sure if this is a voting situation, but I agree with what Zachary said
above.
Since we're already speaking about tests, it looks like the new DataBufferLLVM
class could use a unit test or two, just so we get in the habit of writing
those.
https://reviews.llvm
Author: labath
Date: Fri Feb 24 05:17:40 2017
New Revision: 296107
URL: http://llvm.org/viewvc/llvm-project?rev=296107&view=rev
Log:
Attempt to fix windows unit tests
In LLVM r296049, IPDBSession::getGlobalScope lost its constness. Adjust
the unittest to account for that.
Modified:
lldb/trun
omjavaid updated this revision to Diff 89642.
omjavaid edited the summary of this revision.
omjavaid added a comment.
Herald added a subscriber: srhines.
@labath
Hi I have updated diff with corrections.
Thanks!
https://reviews.llvm.org/D29669
Files:
include/lldb/Host/common/NativeBreakpoint
labath updated this revision to Diff 89645.
labath added a comment.
Switch SBBreakpoint to weak_ptr. This diff is pretty big but it amounts to
s/m_opaque_sp/m_opaque_wp and inserting a lock at the beginning of every
function. Since I had to touch them anyway, I took the opportunity to upgrade
the
labath accepted this revision.
labath added a comment.
lgtm, thanks.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/main.cpp:30
+
+ hw_break_mutex.lock();
+
I know it's only
labath created this revision.
All the existing channels have beens switched to the new mechanism and
this code is now unused.
https://reviews.llvm.org/D30334
Files:
include/lldb/Core/Log.h
source/API/SBCommandReturnObject.cpp
source/Core/Log.cpp
Index: source/Core/Log.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296119: Hardware breakpoints for Linux on Arm/AArch64
targets (authored by omjavaid).
Changed prior to commit:
https://reviews.llvm.org/D29669?vs=89642&id=89654#toc
Repository:
rL LLVM
https://revie
Author: omjavaid
Date: Fri Feb 24 07:27:31 2017
New Revision: 296119
URL: http://llvm.org/viewvc/llvm-project?rev=296119&view=rev
Log:
Hardware breakpoints for Linux on Arm/AArch64 targets
Please look at below differential link for upstream discussion.
Differential revision: https://reviews.llvm
tberghammer added a comment.
Thank you the comments. Based on them I have the following proposal:
- Add a new property to value object with name "m_is_dereference_of_parent"
- Add a new static method named "CreateCopy(name, valobj,
is_dereference_of_parent)" to ValueObject and to SBValue what wi
I left out unit tests since we'd essentially be duplicating the unit tests
of MemoryBuffer, and because it involves the file system (also this is
temporary code until DataBuffer stuff goes away). Lmk if you disagree
though
On Fri, Feb 24, 2017 at 2:53 AM Pavel Labath via Phabricator <
revi...@revie
I am going to move the constructor to private for now, this should
eliminate any disagreement about whether to add null checks, as it is now
literally impossible to construct one with a null pointer. For now this
doesn't matter since nobody is even using the MemoryBuffer constructor
except from in
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks fine.
It reads a little odd to me that the BreakpointSP recipient of GetSP is
generally called opaque_sp after the patch. Historically it makes sense
because it was the result o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296159: Delete DataBufferMemoryMap. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D30054?vs=89547&id=89701#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30054
Files:
Author: zturner
Date: Fri Feb 24 12:56:49 2017
New Revision: 296159
URL: http://llvm.org/viewvc/llvm-project?rev=296159&view=rev
Log:
Delete DataBufferMemoryMap.
After a series of patches on the LLVM side to get the mmaping
code up to compatibility with LLDB's needs, it is now ready
to go, which
jingham added a comment.
I also thought about having the synthetic child provider mark up the special
child value objects when it made them. It bugs me a little but that you
couldn't, for instance, have a synthetic child provider that doesn't display a
child that is the result of the dereferen
Author: jmolenda
Date: Fri Feb 24 22:06:09 2017
New Revision: 296238
URL: http://llvm.org/viewvc/llvm-project?rev=296238&view=rev
Log:
DataBufferMemoryMap.cpp out, DataBufferLLVM.cpp in. Unbreak the build.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodepr
Author: jmolenda
Date: Fri Feb 24 23:43:51 2017
New Revision: 296243
URL: http://llvm.org/viewvc/llvm-project?rev=296243&view=rev
Log:
Three LoadLibCxxFormatters formatters were given a regex string to
match but the 'is_regex' argument was not passed as true. Not sure
this is causing a bug, but n
krytarowski created this revision.
krytarowski added a project: LLDB.
Native Thread ID is retrieved with _lwp_self() on NetBSD.
The returned value is of type int32_t, but for consistency with other Operating
Systems cast it to uint64_t.
Sponsored by
Repository:
rL LLVM
https://reviews.llv
21 matches
Mail list logo
