Author: labath
Date: Mon Feb 20 05:35:33 2017
New Revision: 295651
URL: http://llvm.org/viewvc/llvm-project?rev=295651&view=rev
Log:
Fix a couple of corner cases in NameMatches
Summary:
I originally set out to move the NameMatches closer to the relevant
function and add some unit tests. However,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295651: Fix a couple of corner cases in NameMatches
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30094?vs=5&id=89102#toc
Repository:
rL LLVM
https://reviews.llvm.org/
labath created this revision.
The code was attempting to copy the shared pointer member in order to
guarantee atomicity, but this is not enough. Instead, protect the
pointer with a proper read-write mutex.
This bug was present here for a long time, but my recent refactors must
have altered the ti
labath created this revision.
The main difference here is that in the WINLOG macros you can specify
log categories per call, whereas here you have to go the usual lldb
route of getting a Log* variable first. While this means you have to
write at least two statements, it usually means that each sta
labath added a comment.
Just found this lying on the bottom of my stack. Ed, if you don't object, I'd
like to check in it. I think it is quite a safe change, so we probably don't
need to do too much testing.
https://reviews.llvm.org/D27126
___
lld
clayborg added a comment.
LGTM, but Pavel should give the ok as well.
https://reviews.llvm.org/D29669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
This diff looks good and appreciated for other posix-like systems.
https://reviews.llvm.org/D27126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Mon Feb 20 23:09:26 2017
New Revision: 295694
URL: http://llvm.org/viewvc/llvm-project?rev=295694&view=rev
Log:
Fix spelling mistake.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
Modified:
lldb/trunk/source/Plugins/ExpressionParse
