labath added a subscriber: lldb-commits.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you for the patch.
https://reviews.llvm.org/D30005
___
lldb-commits mailing list
lldb-commits@list
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks.
Really splitting hairs now, but could you also update the test to check for the
return value. :)
https://reviews.llvm.org/D29964
___
ll
Author: labath
Date: Thu Feb 16 09:32:19 2017
New Revision: 295328
URL: http://llvm.org/viewvc/llvm-project?rev=295328&view=rev
Log:
Fix build due to clang r295311
BuiltinType::Kind::OCLNDRange was removed.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/S
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please add Xcode changes I sent you offline and this will be good to go.
https://reviews.llvm.org/D29964
___
lldb-commits mailing l
kubamracek added inline comments.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long
idx, const char
clayborg added inline comments.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long
idx, const char *
kubamracek added inline comments.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long
idx, const char
Author: kuba.brecka
Date: Thu Feb 16 11:42:33 2017
New Revision: 295342
URL: http://llvm.org/viewvc/llvm-project?rev=295342&view=rev
Log:
[lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin
TSan now has the ability to report races on "external" object, i.e. any library
class
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295342: [lldb] Add support for "external" reports in
ThreadSanitizer LLDB plugin (authored by kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D30024?vs=88654&id=88751#toc
Repository:
Author: labath
Date: Thu Feb 16 12:12:04 2017
New Revision: 295345
URL: http://llvm.org/viewvc/llvm-project?rev=295345&view=rev
Log:
NPL: Fix single step workaround
While refactoring the code in r293046 I made a very basic error -
relying on destructor side-effects of a copyable object. Fix that
labath added a comment.
It does not seem too controversial, but I am not very confident reviewing lit
changes. @beanz, could you take a look at this?
Comment at: lit/lit.cfg:124
-debugserver = lit.util.which('debugserver', llvm_tools_dir)
-lldb = lit.util.which('lldb', llvm_
Author: sylvestre
Date: Thu Feb 16 12:45:27 2017
New Revision: 295352
URL: http://llvm.org/viewvc/llvm-project?rev=295352&view=rev
Log:
Reindent the code to avoid an error with gcc:
error: this ‘else’ clause does not guard... [-Werror=misleading-indentation]
Modified:
lldb/trunk/source/Host/
Author: zturner
Date: Thu Feb 16 13:38:21 2017
New Revision: 295368
URL: http://llvm.org/viewvc/llvm-project?rev=295368&view=rev
Log:
Finish breaking the dependency from Utility.
Differential Revision: https://reviews.llvm.org/D29964
Added:
lldb/trunk/include/lldb/Host/PseudoTerminal.h
l
Modified: lldb/trunk/source/Host/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/CMakeLists.txt?rev=295368&r1=295367&r2=295368&view=diff
==
--- lldb/trunk/source/Host/CMakeLists.txt (original
Author: zturner
Date: Thu Feb 16 14:15:26 2017
New Revision: 295369
URL: http://llvm.org/viewvc/llvm-project?rev=295369&view=rev
Log:
Fix build
Modified:
lldb/trunk/source/Utility/VASprintf.cpp
lldb/trunk/unittests/Utility/VASprintfTest.cpp
Modified: lldb/trunk/source/Utility/VASprintf.c
mgorny updated this revision to Diff 88771.
mgorny edited the summary of this revision.
https://reviews.llvm.org/D29985
Files:
lit/lit.cfg
lit/lit.site.cfg.in
Index: lit/lit.site.cfg.in
===
--- lit/lit.site.cfg.in
+++ lit/lit.s
mgorny marked an inline comment as done.
mgorny added a comment.
Following @labath's suggestion, I've changed my approach a little. Now I'm
using PATH lookup only for CC/CXX, while for remaining tools I'm using either
llvm_tools_dir or lldb_tools_dir appropriately.
https://reviews.llvm.org/D29
zturner created this revision.
Herald added a subscriber: mgorny.
This depends on https://reviews.llvm.org/D30010 going in first, but assuming
that's successful, this patch updates LLDB to use LLVM's memory mapping instead
of `DataBufferMemoryMap`. Since this also makes `DataBufferMemoryMap`
o
Author: kamil
Date: Thu Feb 16 19:58:30 2017
New Revision: 295400
URL: http://llvm.org/viewvc/llvm-project?rev=295400&view=rev
Log:
Add myself to CODE_OWNERS.txt for NetBSD
Modified:
lldb/trunk/CODE_OWNERS.txt
Modified: lldb/trunk/CODE_OWNERS.txt
URL:
http://llvm.org/viewvc/llvm-project/lld
20 matches
Mail list logo
