Author: labath
Date: Mon Feb 13 05:03:17 2017
New Revision: 294939
URL: http://llvm.org/viewvc/llvm-project?rev=294939&view=rev
Log:
Clean up debug logging
Summary:
We've had two ways to print a "debug" log message.
- Log::GetDebug() was testing a Stream flag which was never set.
- Log::Debug() w
Author: labath
Date: Mon Feb 13 05:03:24 2017
New Revision: 294940
URL: http://llvm.org/viewvc/llvm-project?rev=294940&view=rev
Log:
Remove some dead code from ProcessPOSIXLog
Modified:
lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIXLog.cpp
lldb/trunk/source/Plugins/Process/POSIX/Pro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294939: Clean up debug logging (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D29823?vs=87987&id=88175#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29823
Files:
lldb/
labath created this revision.
Herald added a subscriber: mgorny.
It turns out listing each library twice is not enough to resolve all
references in a debug build on linux - a number of executables fails to
link with random symbols missing. Increasing the number to three seems
to be enough. The cho
Author: labath
Date: Mon Feb 13 05:56:19 2017
New Revision: 294944
URL: http://llvm.org/viewvc/llvm-project?rev=294944&view=rev
Log:
Try to fix windows build (broken by r294939)
log->Debug is gone, switch to using log->Verbose
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/Debugg
labath created this revision.
Herald added a subscriber: aprantl.
We currently have two log channel registration mechanisms. One uses a
set of function pointers and the other one is based on the
PluginManager.
The PluginManager dependency is unfortunate, as logging
is also used in lldb-server, an
Is it possible to add some unittests for this? In addition to just
tests=good, it would also serve as documentation for the new api
On Mon, Feb 13, 2017 at 9:09 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath created this revision.
> Herald added a subscriber: aprantl.
labath added a comment.
I actually did add tests for that. :)
I didn't try to be super-exhaustive, but I think they provide reasonable
coverage. I'd be happy to add more, if you notice parts that are missing it.
https://reviews.llvm.org/D29895
__
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D29895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
zturner added inline comments.
Comment at: include/lldb/Core/Log.h:74
+ llvm::ArrayRef categories,
+ uint32_t default_flags, std::atomic &log_ptr);
+ static void Unregister(llvm::StringRef name);
Not sure I like the id
Author: cbieneman
Date: Mon Feb 13 15:16:01 2017
New Revision: 294986
URL: http://llvm.org/viewvc/llvm-project?rev=294986&view=rev
Log:
[CMake] Adding API dependency on Utility
Utility is directly referenced from API.
Modified:
lldb/trunk/source/API/CMakeLists.txt
Modified: lldb/trunk/sourc
zturner created this revision.
Herald added a subscriber: mgorny.
This completely removes the dependency from `lldbUtility` -> `lldbCore` and
`lldbTarget`. This was done with the following restructure:
1. `ProcessStructReader`: `Utility` -> `Target`
2. `ModuleCache`: `Utility` -> `Target`
3. `R
Author: cbieneman
Date: Mon Feb 13 15:19:53 2017
New Revision: 294987
URL: http://llvm.org/viewvc/llvm-project?rev=294987&view=rev
Log:
[CMake] Adding API dependency on Utility
Utility is directly referenced from Breakpoint.
Modified:
lldb/trunk/source/Breakpoint/CMakeLists.txt
Modified: ll
Author: gclayton
Date: Mon Feb 13 15:34:58 2017
New Revision: 294990
URL: http://llvm.org/viewvc/llvm-project?rev=294990&view=rev
Log:
FindFunctions now works again with mangled names.
Added:
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/
lldb/trunk/packages/Python/l
Author: gclayton
Date: Mon Feb 13 16:04:02 2017
New Revision: 294991
URL: http://llvm.org/viewvc/llvm-project?rev=294991&view=rev
Log:
Fix buildbots.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
Modified:
lldb/trunk/packages/Python/lldbsuite
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
https://reviews.llvm.org/D29909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg added a comment.
Hopefully we are maintaining the SVN history for these files? Hard to tell from
the patch.
https://reviews.llvm.org/D29909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
zturner added a comment.
I'm not sure, it's a bit of black magic :-/ I use git with mono-repo, and
there is a bunch of magic that happens at the git-svn layer. When I run `git
status` it shows me that the files are renames / moves, so I hope that means
that it preserves the history when it go
zturner added a comment.
`git log --follow` seems to understand. Is that sufficient to guarantee that
it will be retained on the SVN side?
D:\src\llvm-mono>git log --follow lldb/source/Target/ModuleCache.cpp
commit 07bf36c627f3a4304dbb8ea3f8347110a025bd93
Author: Zachary Turner
Date:
clayborg added a comment.
Anyone still care about this? It would be nice to move it along or abandon it.
https://reviews.llvm.org/D19603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
clayborg added a comment.
I don't know enough to say for sure. Go ahead and try it with this patch as the
files are pretty simple and losing the history wouldn't be too bad on these
files. If it fails to have history, then you should use an SVN workflow for any
future moves.
https://reviews.l
krytarowski added a comment.
In https://reviews.llvm.org/D29909#675621, @zturner wrote:
> `git log --follow` seems to understand. Is that sufficient to guarantee that
> it will be retained on the SVN side?
On SVN there is need to explicitly rename files to retain history. (`svn mv old
new` o
zturner added a comment.
In https://reviews.llvm.org/D29909#675644, @krytarowski wrote:
> In https://reviews.llvm.org/D29909#675621, @zturner wrote:
>
> > `git log --follow` seems to understand. Is that sufficient to guarantee
> > that it will be retained on the SVN side?
>
>
> On SVN there is
Author: jmolenda
Date: Mon Feb 13 22:55:03 2017
New Revision: 295025
URL: http://llvm.org/viewvc/llvm-project?rev=295025&view=rev
Log:
Before returning a pc value for a stack frame,
run it through the ABI's FixCodeAddress method.
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterC
24 matches
Mail list logo
