[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for AArch64 targets

2017-02-09 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In https://reviews.llvm.org/D29669#670896, @clayborg wrote: > I would prefer to see NativeBreakpoint struct expanded to have more member > variables instead of adding a new hardware breakpoint list. Then you just ask > any breakpoint to enable/disable/remove itself and

[Lldb-commits] [lldb] r294580 - Fix shared library build

2017-02-09 Thread Ismail Donmez via lldb-commits
Author: ismail Date: Thu Feb 9 04:59:33 2017 New Revision: 294580 URL: http://llvm.org/viewvc/llvm-project?rev=294580&view=rev Log: Fix shared library build Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/CMakeLists.txt Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/CMakeList

[Lldb-commits] [lldb] r294583 - Revert r294580 , it didn't fix the shared build

2017-02-09 Thread Ismail Donmez via lldb-commits
Author: ismail Date: Thu Feb 9 06:30:09 2017 New Revision: 294583 URL: http://llvm.org/viewvc/llvm-project?rev=294583&view=rev Log: Revert r294580 , it didn't fix the shared build Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/CMakeLists.txt Modified: lldb/trunk/source/Plugins/Unwin

[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for AArch64 targets

2017-02-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. If it isn't making too much extra code I am fine with it being separate if you believe this is the right way forward. Give it some thought and if you still believe they should be separate, I won't object. It might be nice to send the HardwareBreakpoint structure down t

[Lldb-commits] [lldb] r294597 - Fixed documentation bug found by Ramana who sent a patch to the lldb-dev list.

2017-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Feb 9 11:16:19 2017 New Revision: 294597 URL: http://llvm.org/viewvc/llvm-project?rev=294597&view=rev Log: Fixed documentation bug found by Ramana who sent a patch to the lldb-dev list. Modified: lldb/trunk/www/test.html Modified: lldb/trunk/www/test.html URL: h

[Lldb-commits] [lldb] r294600 - Fixed an issue where AllocatedBlock::ReserveRange does a linear search through reserved ranges.

2017-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Feb 9 11:56:55 2017 New Revision: 294600 URL: http://llvm.org/viewvc/llvm-project?rev=294600&view=rev Log: Fixed an issue where AllocatedBlock::ReserveRange does a linear search through reserved ranges. After many expressions are evaluated we were spending time lookin

[Lldb-commits] [lldb] r294603 - Fix build bots.

2017-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Feb 9 12:21:04 2017 New Revision: 294603 URL: http://llvm.org/viewvc/llvm-project?rev=294603&view=rev Log: Fix build bots. Modified: lldb/trunk/include/lldb/Target/Memory.h lldb/trunk/source/Target/Memory.cpp Modified: lldb/trunk/include/lldb/Target/Memory.h

[Lldb-commits] [lldb] r294611 - Make sure we only load the OS plug-in once.

2017-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Feb 9 12:55:41 2017 New Revision: 294611 URL: http://llvm.org/viewvc/llvm-project?rev=294611&view=rev Log: Make sure we only load the OS plug-in once. Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL: http://ll