krytarowski updated this revision to Diff 87102.
krytarowski added a comment.
Sync this patch with SVN 294071.
It is to be used at least for a reference in further code sharing.
Repository:
rL LLVM
https://reviews.llvm.org/D29266
Files:
source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
krytarowski updated this revision to Diff 87109.
krytarowski added a comment.
Revamp patch after recent changes in LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D29288
Files:
include/lldb/Core/Debugger.h
source/Commands/CommandObjectPlatform.cpp
source/Core/Debugger.cpp
source/C
krytarowski updated this revision to Diff 87120.
krytarowski added a comment.
Typo.
Repository:
rL LLVM
https://reviews.llvm.org/D29288
Files:
include/lldb/Core/Debugger.h
source/Commands/CommandObjectPlatform.cpp
source/Core/Debugger.cpp
source/Core/ModuleList.cpp
source/Host/comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294113: Remove LIBLLDB_LOG_VERBOSE category (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D29510?vs=87046&id=87125#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29510
Author: labath
Date: Sat Feb 4 18:44:54 2017
New Revision: 294113
URL: http://llvm.org/viewvc/llvm-project?rev=294113&view=rev
Log:
Remove LIBLLDB_LOG_VERBOSE category
Summary:
Per discussion in D28616, having two ways two request logging (log
enable lldb XXX verbose && log enable -v lldb XXX) i
krytarowski added a comment.
Related https://reviews.llvm.org/D29552
I'm requesting help to test this patch on !NetBSD with and without
`LLVM_THREADING_USE_STD_CALL_ONCE` defined in `"llvm/Support/Threading.h"`.
This issue is blocking me from adding functional changes for the NetBSD port.
Rep
Author: labath
Date: Sat Feb 4 19:04:10 2017
New Revision: 294114
URL: http://llvm.org/viewvc/llvm-project?rev=294114&view=rev
Log:
Clean up PlatformLinux code
don't create a platform.linux setting category, as it contains no
actual settings, and I don't forsee adding any soon. Also remove some
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Just sync once more please and I think we're done. We've removed enough code to
offset the remaining bit of duplication here. DebugProcess is the only
remaining candidate for merging, but we d
labath added inline comments.
Comment at: include/lldb/Core/Debugger.h:379
lldb::ListenerSP m_forward_listener_sp;
- std::once_flag m_clear_once;
+ llvm::once_flag m_clear_once;
The code in llvm says you should only ever use the LLVM_DEFINE_ONCE_FLAG to
d
krytarowski added a comment.
I'm syncing the code to get the changes from SVN revision 294114 "Clean up
PlatformLinux code"
Repository:
rL LLVM
https://reviews.llvm.org/D29266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
krytarowski updated this revision to Diff 87126.
krytarowski added a comment.
Catch up after r294114 - Clean up PlatformLinux code
Repository:
rL LLVM
https://reviews.llvm.org/D29266
Files:
source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
source/Plugins/Platform/NetBSD/PlatformNetBSD.h
krytarowski added a comment.
OK to land it? FreeBSD can reuse almost exact the same code. I'm not sure if
it's compatible with their Process Plugin.
Repository:
rL LLVM
https://reviews.llvm.org/D29266
___
lldb-commits mailing list
lldb-commits@l
krytarowski added inline comments.
Comment at: include/lldb/Core/Debugger.h:379
lldb::ListenerSP m_forward_listener_sp;
- std::once_flag m_clear_once;
+ llvm::once_flag m_clear_once;
labath wrote:
> The code in llvm says you should only ever use the LLVM_D
krytarowski added a comment.
I've tried to build the LLDB code with mechanically * replaced `std::call_once`
-> `llvm::call_once` and `std::once_flag` -> `llvm::once_flag`:
--- /public/llvm/include/llvm/Support/Threading.h 2017-02-05
00:15:00.769574623 +0100
+++ /usr/pkg/include/llvm/Su
krytarowski added a comment.
Test results for the above patch for LLVM and LLDB with "mechanical" switch to
`llvm::call_once`.
===
Test Result Summary
===
Test Methods: 1224
Reruns:1
Success: 268
Expected Failure:
krytarowski added a comment.
Once someone could explain to me why `SymbolFileDWARF::GetCachedSectionData`
cannot be switched mechanically to `llvm::call_once`, I would like to propose
this revamped interface to llvm.
Repository:
rL LLVM
https://reviews.llvm.org/D29288
___
16 matches
Mail list logo
