labath added a comment.
Any objections to this, Zach?
https://reviews.llvm.org/D28858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Sorry forgot about this, looks good
On Mon, Jan 23, 2017 at 7:55 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> Any objections to this, Zach?
>
>
> https://reviews.llvm.org/D28858
>
>
>
>
___
lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292795: Replace getcwd with the llvm equivalent (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D28858?vs=84828&id=85399#toc
Repository:
rL LLVM
https://reviews.llvm.org/D288
Author: labath
Date: Mon Jan 23 09:56:45 2017
New Revision: 292795
URL: http://llvm.org/viewvc/llvm-project?rev=292795&view=rev
Log:
Replace getcwd with the llvm equivalent
Summary:
getcwd() is not available (well.. um.. deprecated?) on windows, and the way
PosixApi.h is providing it causes stran
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D28944
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D28808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
labath created this revision.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D29036
Files:
include/lldb/Core/State.h
source/Plugins/Process/Linux/NativeProcessLinux.cpp
unittests/Core/CMakeLists.txt
unittests/Core/StateTest.cpp
Index: unittests/Core/StateTest.cpp
===
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close, just add a test for a bad value since someone can have code like:
StateType state;
llvm::formatv("{0}", state);
Just to make sure we don't crash during logging. C
clayborg added inline comments.
Comment at: unittests/Core/StateTest.cpp:19
+ EXPECT_EQ("exited", llvm::formatv("{0}", eStateExited).str());
+ EXPECT_EQ("stopped", llvm::formatv("{0}", eStateStopped).str());
+}
Add a test like:
```
EXPECT_EQ("(null)", llvm::fo
labath updated this revision to Diff 85419.
labath added a comment.
In this case, StateAsCString was returning a pointer to a static buffer in a
scarily non-thread-safe way. I've changed it to print "unknown" instead and test
for that.
https://reviews.llvm.org/D29036
Files:
include/lldb/Core/
boris.ulasevich added a comment.
In https://reviews.llvm.org/D28945#651806, @jingham wrote:
> The plans should do whatever cleanup they are going to do when they get
> popped, and should not rely on the destructors to do this work.
Yes, you already made a note a time ago:
r123869 | jingham |
boris.ulasevich updated this revision to Diff 85424.
boris.ulasevich added a comment.
description update
https://reviews.llvm.org/D28945
Files:
lldb/include/lldb/Target/Thread.h
lldb/include/lldb/Target/ThreadPlan.h
lldb/source/Target/Thread.cpp
Index: lldb/source/Target/Thread.cpp
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as the test suite is happy.
https://reviews.llvm.org/D29036
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
I can't think of a case where you would need the discarded plans to stick
around across a function call, I don't think you need to preserve that stack.
I do worry a bit about how the complet
Author: jmolenda
Date: Mon Jan 23 22:16:03 2017
New Revision: 292880
URL: http://llvm.org/viewvc/llvm-project?rev=292880&view=rev
Log:
weak-link debugserver against the LoggingSupport framework;
systems without this framework will not get a link error.
Modified:
lldb/trunk/tools/debugserve
Author: jmolenda
Date: Mon Jan 23 22:43:40 2017
New Revision: 292882
URL: http://llvm.org/viewvc/llvm-project?rev=292882&view=rev
Log:
Enable compression capability in debugserver for all of ios/watchos/tvos
environments.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modifie
Author: jmolenda
Date: Mon Jan 23 23:06:14 2017
New Revision: 292884
URL: http://llvm.org/viewvc/llvm-project?rev=292884&view=rev
Log:
Prefer lzfse if it is an available compression method (this was
defaulting to zlib previously).
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRe
Author: jmolenda
Date: Tue Jan 24 00:09:06 2017
New Revision: 292890
URL: http://llvm.org/viewvc/llvm-project?rev=292890&view=rev
Log:
Fix the last commit; compression was being enabled on mac native
which led to
ERROR: test_auxv_chunked_reads_work_debugserver
(tools/lldb-server/TestGdbRemoteAux
18 matches
Mail list logo
