labath added inline comments.
Comment at: source/Core/Log.cpp:78
+ char *text;
+ vasprintf(&text, format, args);
+ message << text;
zturner wrote:
> dancol wrote:
> > I usually implement printf-into-std::string by using `vsnprintf` to figure
> > out how many
Author: labath
Date: Wed Jan 18 05:00:26 2017
New Revision: 292360
URL: http://llvm.org/viewvc/llvm-project?rev=292360&view=rev
Log:
Add a more succinct logging syntax
This adds the LLDB_LOG macro, which enables one to write more succinct log
statements.
if (log)
log->Printf("log something: %d"
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292360: Add a more succinct logging syntax (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D27459?vs=84690&id=84814#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27459
F
Author: labath
Date: Wed Jan 18 06:29:51 2017
New Revision: 292364
URL: http://llvm.org/viewvc/llvm-project?rev=292364&view=rev
Log:
Fix windows build for previous commit
We get an error about a redefinition of getcwd(). This seems to fix it.
Modified:
lldb/trunk/unittests/Core/LogTest.cpp
abidh updated this revision to Diff 84817.
abidh added a comment.
Added the check to avoid integer underflow.
https://reviews.llvm.org/D28808
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
=
abidh added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3999
+ // time, we take a maximum guess here.
+ stub_max_size -= 32 + 32 + 6;
m_max_memory_size = stub_max_size;
clayborg wrote:
> You need to check "
labath created this revision.
getcwd() is not available (well.. um.. deprecated?) on windows, and the way
PosixApi.h is providing it causes strange compile errors when it's included in
the wrong order. The best way to avoid that is to just not use chdir.
This replaces all uses of getcwd in generi
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few cleanups on the logging. See inlined comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4004
+// hope that data being wr
Author: labath
Date: Wed Jan 18 11:31:55 2017
New Revision: 292414
URL: http://llvm.org/viewvc/llvm-project?rev=292414&view=rev
Log:
Fix new Log unit test
the test was flaky because I specified the format string for the process id
incorrectly. This should fix it.
Modified:
lldb/trunk/unittes
abidh updated this revision to Diff 84857.
abidh added a comment.
Updated log calls as advised.
https://reviews.llvm.org/D28808
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
===
abidh marked 2 inline comments as done.
abidh added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4006-4007
+if (log)
+ log->Warning("Packet size is too small."
+ "LLDB may face problems while writing me
Author: jmolenda
Date: Wed Jan 18 18:20:29 2017
New Revision: 292454
URL: http://llvm.org/viewvc/llvm-project?rev=292454&view=rev
Log:
Fix a problem with the new dyld interface code -- when a new process
starts up, we need to clear the target's image list and only add
the binaries into the target
12 matches
Mail list logo
