[Lldb-commits] [lldb] r290957 - Add a debuginfo version check for RenderScript modules

2017-01-04 Thread Luke Drummond via lldb-commits
Author: ldrumm Date: Wed Jan 4 06:11:04 2017 New Revision: 290957 URL: http://llvm.org/viewvc/llvm-project?rev=290957&view=rev Log: Add a debuginfo version check for RenderScript modules Added an extra field parser to the `RSModuleDescriptor` class enabling us to check whether the versions of LL

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I would skip the SBDwarf.h and just make a simple DWARF opcode parser all in python. We only need it to handle the opcodes that are currently used by any supported targets. Since

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2017-01-04 Thread Aetf via Phabricator via lldb-commits
aetf marked 2 inline comments as done. aetf added a comment. What do I do next? Could you help me commit and push this? since I don't have write access. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/main.cpp:22 { -int a = 10; +int a = 10; + ---

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2017-01-04 Thread Hafiz Abid Qadeer via Phabricator via lldb-commits
abidh added a comment. > What do I do next? Could you help me commit and push this? since I don't have > write access. I will commit it for you. https://reviews.llvm.org/D24711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

2017-01-04 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: zturner, clayborg. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This is a rework of https://reviews.llvm.org/D25783, which was blocked by my objections to using pwrite wholesale. This version keeps the benefits o

[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

2017-01-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This change removes support for using a FILE* instead of a file descriptor. This needs to be fixed. The old Read function used to do this: ssize_t bytes_read = -1; if (Descri

[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

2017-01-04 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The way this deals with it is by using `GetDescriptor()` which extracts the raw fd from FILE *, and then always deals with those. I guess this has the potential of bypassing any libc cache that FILE * may be using. I don't know whether we care about that, but if we do th

[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

2017-01-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In https://reviews.llvm.org/D28305#635877, @labath wrote: > The way this deals with it is by using `GetDescriptor()` which extracts the > raw fd from FILE *, and then always deals with those. I guess this has the > potential of bypassing any libc cache that FILE * may

Re: [Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

2017-01-04 Thread Zachary Turner via lldb-commits
Honestly I would just assume we blanket kill FILE* across the entire codebase. It's non-portable, doesn't interoperate with Python 3, doesn't interoperate with C++ library facilities, and is clunky to deal with on Windows since most of the useful APIs won't accept one. On Wed, Jan 4, 2017 at 2:04

[Lldb-commits] Buildbot numbers for the week of 12/18/2016 - 12/24/2016

2017-01-04 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 12/18/2016 - 12/24/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

[Lldb-commits] Ð’uildbot numbers for the week of 12/25/2016 - 12/31/2016

2017-01-04 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 12/25/2016 - 12/31/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro