labath updated this revision to Diff 79050.
labath added a comment.
Changes since last version:
- Rename the class to Timeout<>, to reflect the fact that I'd like to use it as
a general method for describing timeouts.
- add "using namespace std::chrono" to files with significat chrono usage.
I
hhellyer updated this revision to Diff 79051.
hhellyer added a comment.
Updated to add the test executables and core files.
https://reviews.llvm.org/D26676
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/gcore/
packages/Python/lldbsuite/test/functionalities/postmo
hhellyer added a comment.
@labath If you are happy with the tests and the size of their supporting files
I'll land this, otherwise let me know if anything needs changing.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@l
labath added a comment.
I just tried it, and these tests run fine without the executable file. Just
remove those, and I think we're ready.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/gcore/TestGCore.py:38
+def do_test(self, filename, pid
hhellyer updated this revision to Diff 79056.
hhellyer added a comment.
Updating patch to remove executables and create empty targets in the test cases.
https://reviews.llvm.org/D26676
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/gcore/
packages/Python/lldbsuit
labath added a comment.
Ed, have you had a chance to try this out? I'd like to put this in soon.
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. One question though: do we always have a shared library that
contains the ASAN runtime? If so, then we can actually put the array of short
to long description into the ASAN dyl
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
seems reasonable.
https://reviews.llvm.org/D27010
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
hhellyer added a comment.
I'll land these changes tomorrow morning (UK time) so I can watch the builds
and check there's no problems with the tests.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
hhellyer added a comment.
I'll land these changes tomorrow morning (UK time) so I can watch the builds
and check there's no problems with the tests.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Much better, looks good.
https://reviews.llvm.org/D26971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
filcab added a comment.
I have some minor fixes I'd like to see.
If it's prefixed by "Nit: " it's a really minor one and I'm ok with it as is if
that's what you prefer.
Thank you,
Filipe
Comment at:
source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRunti
kubabrecka added a comment.
Thanks for these comments, I'll have them run by more people before committing
this (I'm not a native English speaker). These really need to be as
user-focused as possible, so I'm really against stuff like "not owned pointer",
because that's not something we should
filcab added inline comments.
Comment at:
source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp:220
+ } else if (description == "stack-overflow") {
+return "Stack overflow detected (recursion too deep)";
+ } else if (description == "null-deref"
Hello everyone,
Below are some buildbot numbers for the last week of 11/13/2016 -
11/19/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
inglorion accepted this revision.
inglorion added a reviewer: inglorion.
inglorion added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D27081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
Author: ttsugrii
Date: Wed Nov 23 19:34:43 2016
New Revision: 287848
URL: http://llvm.org/viewvc/llvm-project?rev=287848&view=rev
Log:
Fix a comparison of integers of different signs warning.
source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:403:21:
warning: comparison
nitesh.jain created this revision.
nitesh.jain added reviewers: labath, clayborg, zturner.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits.
https://reviews.llvm.org/D27085
Files:
packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_hits/main.cpp
Index:
18 matches
Mail list logo
