hhellyer updated this revision to Diff 78524.
hhellyer added a comment.
Updating the patch to include the test cases and scripts to produce the core
dumps.
I haven't included the core dumps and when I do I'll need to update the pid and
tid values in the test scripts. That can wait until we've dec
labath added a comment.
We probably don't want to check in zillions of core files, but I believe having
a couple of them is fine, particularly when care is taken to minimize their
size. I believe the benefits (being able to run tests on a piece of code in a
reproducible and platform-independent
Author: zturner
Date: Fri Nov 18 11:55:04 2016
New Revision: 287354
URL: http://llvm.org/viewvc/llvm-project?rev=287354&view=rev
Log:
Resubmit "Remove an output-parameter from Variable function".
The scanning algorithm had a few little subtleties that I
overlooked, but this patch should fix every
Author: zturner
Date: Fri Nov 18 13:23:39 2016
New Revision: 287367
URL: http://llvm.org/viewvc/llvm-project?rev=287367&view=rev
Log:
Re-add the StringRef interface changes for Variable.
This concludes the changes I originally tried to make and then
had to back out. This way if anything is still
If we are going to do that, I wonder if we should start having tests share
their inputs. We don’t do that for source files because the cost of
duplication is so small, and then you don’t have the hassle of adding something
to a source fie for test A messes up test B. But for binaries like core
I didn’t see this patch go up for review. The parameter you removed might have
been vestigial or might have been one that the owner of this code was planning
to do something with. Anyway, this seems to go beyond purely formal changes
and so should have been discussed. My apologies if I just m
I admit I've been moving somewhat fast with these changes. The parameter
in question was only used in one logging statement, so the benefit did not
seem worth the added cost of complexity. But you're right, that involved a
judgement call on my part that I didn't vet first.
+Enrico Granata , who
Not a big deal. Formal changes are fine, but even dead code in areas you don’t
work on might represent a work in progress, so it’s good to ask first. For
instance, Enrico and Greg originally had plans for “frame var” to be able to
print slices of arrays - that’s presumably the dead code functi
Author: zturner
Date: Fri Nov 18 14:44:46 2016
New Revision: 287376
URL: http://llvm.org/viewvc/llvm-project?rev=287376&view=rev
Log:
Change CreateTarget and dependents to accept StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/OptionGroupArchitecture.h
lldb/trunk/include/lldb/Tar
I tend to agree with Jim's point. I have sometimes put in things that
look like "dead/vestigial code", which I am actually either planning to
use later on, or actively using somewhere else. This is a quite
realistic scenario due to Swift support for LLDB existing in an entirely
separate univers
Author: jingham
Date: Fri Nov 18 16:06:10 2016
New Revision: 287386
URL: http://llvm.org/viewvc/llvm-project?rev=287386&view=rev
Log:
Fix "thread step until" handling of multiple line inputs.
Also document that it handles same, and add some tests.
Added:
lldb/trunk/packages/Python/lldbsuite/
Author: enrico
Date: Fri Nov 18 17:18:11 2016
New Revision: 287397
URL: http://llvm.org/viewvc/llvm-project?rev=287397&view=rev
Log:
Removing myself from CODE_OWNERS, and distributing those duties among other
members of the community
That's All, Folks
Modified:
lldb/trunk/CODE_OWNERS.txt
Author: zturner
Date: Fri Nov 18 17:22:42 2016
New Revision: 287401
URL: http://llvm.org/viewvc/llvm-project?rev=287401&view=rev
Log:
Convert CommandHistory functions to StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandHistory.h
lldb/trunk/source/Interpreter/CommandHistory.
Author: cbieneman
Date: Fri Nov 18 17:31:53 2016
New Revision: 287408
URL: http://llvm.org/viewvc/llvm-project?rev=287408&view=rev
Log:
[CMake] NFC. Updating CMake dependency specifications
This patch updates a bunch of places where add_dependencies was being
explicitly called to add dependencie
Author: zturner
Date: Fri Nov 18 17:32:37 2016
New Revision: 287409
URL: http://llvm.org/viewvc/llvm-project?rev=287409&view=rev
Log:
Fix some build errors.
Modified:
lldb/trunk/source/Interpreter/CommandHistory.cpp
Modified: lldb/trunk/source/Interpreter/CommandHistory.cpp
URL:
http://llvm
Author: zturner
Date: Fri Nov 18 18:50:29 2016
New Revision: 287412
URL: http://llvm.org/viewvc/llvm-project?rev=287412&view=rev
Log:
Fix some accidental Prints of StringRefs that snuck in.
Modified:
lldb/trunk/source/Symbol/Variable.cpp
lldb/trunk/source/Target/TargetList.cpp
Modified:
zturner created this revision.
zturner added reviewers: jingham, beanz, clayborg, labath.
zturner added a subscriber: lldb-commits.
The purpose of this patch is to demonstrate my proposed new API to the `Args`
class. There are a couple of things I'm trying to demonstrate here:
1. range-based fo
17 matches
Mail list logo
