enlight updated this revision to Diff 74622.
enlight added a comment.
Renamed placeholder c-strings.
Repository:
rL LLVM
https://reviews.llvm.org/D25592
Files:
tools/lldb-mi/MICmnLLDBUtilSBValue.cpp
tools/lldb-mi/MICmnLLDBUtilSBValue.h
Index: tools/lldb-mi/MICmnLLDBUtilSBValue.h
===
ki.stfu accepted this revision.
ki.stfu added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22
+static const char *kUnknownValue = "??";
+static const char *kCompositeValuePlaceholder = "{...}";
+
---
ki.stfu requested changes to this revision.
ki.stfu added inline comments.
This revision now requires changes to proceed.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
if (!bOk)
-return m_pUnkwn;
+return kUnresolvedValue;
After couple of min
enlight updated this revision to Diff 74628.
enlight marked an inline comment as done.
enlight added a comment.
Rename `kUnresolvedValue` back to `kUknownValue`.
Repository:
rL LLVM
https://reviews.llvm.org/D25592
Files:
tools/lldb-mi/MICmnLLDBUtilSBValue.cpp
tools/lldb-mi/MICmnLLDBUtilS
enlight marked an inline comment as done.
enlight added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
if (!bOk)
-return m_pUnkwn;
+return kUnresolvedValue;
ki.stfu wrote:
> After couple of minutes I see the lack of logic the
labath added a comment.
First round of comments from me :).
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:248
+
+if (lowest_addr.find(module_name) == lowest_addr.end()) {
+ lowest_addr[module_name] =
If you use the `emplace` function,
Author: enlight
Date: Fri Oct 14 07:58:02 2016
New Revision: 284231
URL: http://llvm.org/viewvc/llvm-project?rev=284231&view=rev
Log:
[LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class
Summary:
Placeholder c-strings don't need to be instance variables.
Reviewers: ki.stfu, abidh
Subscribers:
This revision was automatically updated to reflect the committed changes.
enlight marked an inline comment as done.
Closed by commit rL284231: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue
class (authored by enlight).
Changed prior to commit:
https://reviews.llvm.org/D25592?vs=74628&id=74667
dvlahovski updated this revision to Diff 74694.
dvlahovski marked 7 inline comments as done.
dvlahovski added a comment.
Resolved Pavel's remarks.
Also added a unit test for the GetMemory function.
https://reviews.llvm.org/D25569
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
so
Author: cbieneman
Date: Fri Oct 14 12:09:55 2016
New Revision: 284250
URL: http://llvm.org/viewvc/llvm-project?rev=284250&view=rev
Log:
[CMake] Populate LLDB.framework's headers directory
Summary:
This patch adds support for installing public headers in LLDB.framework, and
symlinking the headers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284250: [CMake] Populate LLDB.framework's headers directory
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D25570?vs=74543&id=74708#toc
Repository:
rL LLVM
https://review
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:242
+
+ for (const auto &module : modules) {
+name = GetMinidumpString(module.module_name_rva);
I don't know how big the minidumps you're working with are or if per
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jingham
Date: Fri Oct 14 19:04:38 2016
New Revision: 284296
URL: http://llvm.org/viewvc/llvm-project?rev=284296&view=rev
Log:
This test is no longer failing for gmodules.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods2.py
Modified:
lldb/tru
14 matches
Mail list logo
