ki.stfu updated this revision to Diff 70653.
ki.stfu added a comment.
Remove obvious comment
https://reviews.llvm.org/D24331
Files:
source/Core/Log.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
source/Plugins/Process/elf-core/Pr
ki.stfu updated this revision to Diff 70654.
ki.stfu added a comment.
Apply clang-format
https://reviews.llvm.org/D24331
Files:
source/Core/Log.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
source/Plugins/Process/elf-core/Proces
zturner added inline comments.
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1462-1467
@@ -1461,8 +1461,8 @@
const uint32_t segment_permissions =
((load_cmd.initprot & VM_PROT_READ) ? ePermissionsReadable
-
ki.stfu updated this revision to Diff 70656.
ki.stfu marked 3 inline comments as done.
ki.stfu added a comment.
Fixes per Zachary's comments
https://reviews.llvm.org/D24331
Files:
source/Core/Log.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFi
ki.stfu marked an inline comment as done.
Comment at: source/Target/StackFrame.cpp:1425
@@ -1423,3 +1424,3 @@
- if (offset >= pointee->GetByteSize()) {
+ if (offset > 0 && uint64_t(offset) >= pointee->GetByteSize()) {
int64_t index = offset / pointee->GetByteSize();
-
Author: labath
Date: Thu Sep 8 05:07:04 2016
New Revision: 280919
URL: http://llvm.org/viewvc/llvm-project?rev=280919&view=rev
Log:
gdb-remote: Add jModulesInfo packet
Summary:
This adds the jModulesInfo packet, which is the equivalent of qModulesInfo, but
it enables us to
query multiple module
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280919: gdb-remote: Add jModulesInfo packet (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D24236?vs=70409&id=70671#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24236
Author: labath
Date: Thu Sep 8 06:09:14 2016
New Revision: 280922
URL: http://llvm.org/viewvc/llvm-project?rev=280922&view=rev
Log:
Fix test breakage in r280919
It turns out that self.dbg.GetSelectedPlatform().GetTriple() is not a good way
to get the triple of the process, as it returns the inco
labath added a comment.
The reformat is complete, and our main buildbot is (as I think you've already
found out) in the non-experimental mode. As far as I am concerned, we can
proceed with this. If you can't test on linux before hand, just look out for
the emails and be ready to respond. If the
abhishek.aggarwal updated this revision to Diff 70677.
abhishek.aggarwal added a comment.
Removed get() for shared_ptr
https://reviews.llvm.org/D24251
Files:
include/lldb/API/SBSection.h
scripts/interface/SBSection.i
source/API/SBSection.cpp
Index: source/API/SBSection.cpp
==
Author: abhishek
Date: Thu Sep 8 07:22:56 2016
New Revision: 280924
URL: http://llvm.org/viewvc/llvm-project?rev=280924&view=rev
Log:
LLDB: API for iPermission of object file's sections
Summary:
- Added an API to public interface that provides permissions (RWX) of
individual sections of
Author: emaste
Date: Thu Sep 8 08:11:31 2016
New Revision: 280931
URL: http://llvm.org/viewvc/llvm-project?rev=280931&view=rev
Log:
Fix unused variable and integer sign warnings from r280906
Modified:
lldb/trunk/source/Core/Disassembler.cpp
Modified: lldb/trunk/source/Core/Disassembler.cpp
Author: emaste
Date: Thu Sep 8 08:17:42 2016
New Revision: 280933
URL: http://llvm.org/viewvc/llvm-project?rev=280933&view=rev
Log:
Fix -Wcovered-switch-default warning in AppleObjCRuntimeV2.cpp
The switch coveres all possible values. If a new one is added in the
future the compiler will start w
valentinagiusti updated this revision to Diff 70695.
valentinagiusti added a comment.
Improved MPX test Makefile and removed workaround for unnamed register sets,
and rebased according to the new coding style.
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalit
valentinagiusti added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:7
@@ +6,2 @@
+
+include $(LEVEL)/Makefile.rules
Np, thanks for the review and explanations ;)
https://reviews.llvm.org/D2
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D24255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
emaste added a comment.
This change will no longer apply. Is it still desired? If so, can you please
rebase the patch.
https://reviews.llvm.org/D5867
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: valentinagiusti
Date: Thu Sep 8 09:16:45 2016
New Revision: 280942
URL: http://llvm.org/viewvc/llvm-project?rev=280942&view=rev
Log:
Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.
Summary: Signed-off-by: Valentina Giusti
Reviewers: dvlahovski, granata.e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280942: Fix for rL280668, Intel(R) Memory Protection
Extensions (Intel(R) MPX) support. (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D24255?vs=70695&id=70698#toc
Rep
I will try to pick this up again sometime next week. I will also try to
get my test suite working on Linux first so I can find these failures
myself.
On Thu, Sep 8, 2016 at 4:28 AM Pavel Labath wrote:
> labath added a comment.
>
> The reformat is complete, and our main buildbot is (as I think y
Author: labath
Date: Thu Sep 8 11:58:30 2016
New Revision: 280965
URL: http://llvm.org/viewvc/llvm-project?rev=280965&view=rev
Log:
Fix MSVC error from r280919
MSVC did not understand my brace-initializer syntax. :/
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
pieandcakes added a comment.
Would you be willing to please take another look? I think this should be the
fix.
Repository:
rL LLVM
https://reviews.llvm.org/D23026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
22 matches
Mail list logo
