[Lldb-commits] [lldb] r276254 - Add a new DynamicLoader plugin that uses SPI that are in development

2016-07-21 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jul 21 03:30:55 2016 New Revision: 276254 URL: http://llvm.org/viewvc/llvm-project?rev=276254&view=rev Log: Add a new DynamicLoader plugin that uses SPI that are in development for the fall (northern hemisphere) 2016 Darwin platforms to learn about loaded images, instead

Re: [Lldb-commits] [PATCH] D22457: Unify process launching code on linux

2016-07-21 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with 2 minor comments Comment at: source/Host/linux/ProcessLauncherLinux.cpp:28-29 @@ +27,4 @@ + +// If there is no PATH variable specified inside the env

Re: [Lldb-commits] [PATCH] D22457: Unify process launching code on linux

2016-07-21 Thread Pavel Labath via lldb-commits
labath marked 2 inline comments as done. labath added a comment. https://reviews.llvm.org/D22457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276288 - Unify process launching code on linux

2016-07-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jul 21 09:54:03 2016 New Revision: 276288 URL: http://llvm.org/viewvc/llvm-project?rev=276288&view=rev Log: Unify process launching code on linux Summary: We've had two copies of code for launching processes: - one in NativeProcessLinux, used for launching debugged proces

Re: [Lldb-commits] [PATCH] D22457: Unify process launching code on linux

2016-07-21 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276288: Unify process launching code on linux (authored by labath). Changed prior to commit: https://reviews.llvm.org/D22457?vs=64296&id=64894#toc Repository: rL LLVM https://reviews.llvm.org/D22457

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

2016-07-21 Thread Todd Fiala via lldb-commits
tfiala added a comment. That's weird - it shows up as abandoned, but you did check it in, right Pavel? https://reviews.llvm.org/D22404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

2016-07-21 Thread Pavel Labath via lldb-commits
labath added a comment. I also reverted it back, as it was causing some issues (if a specific test case in a test file failed, it still marked the whole file as failed). I'll need revisit this later... https://reviews.llvm.org/D22404 ___ lldb-comm

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

2016-07-21 Thread Todd Fiala via lldb-commits
tfiala added a comment. Ah yes okay, that orients what I heard earlier. Thanks! https://reviews.llvm.org/D22404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276303 - Add check for non-null log instance in PlatformAndroid.

2016-07-21 Thread Oleksiy Vyalov via lldb-commits
Author: ovyalov Date: Thu Jul 21 12:03:25 2016 New Revision: 276303 URL: http://llvm.org/viewvc/llvm-project?rev=276303&view=rev Log: Add check for non-null log instance in PlatformAndroid. Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp Modified: lldb/trunk/source/

[Lldb-commits] [PATCH] D22628: Fixing layout of elf-core file related structures

2016-07-21 Thread Dimitar Vlahovski via lldb-commits
dvlahovski created this revision. dvlahovski added a reviewer: labath. dvlahovski added a subscriber: lldb-commits. The binary layout of prstatus and prpsinfo was wrong. Some of the member variables where not aligned properly and others where with a wrong type (e.g. the time related stuff in prsta

Re: [Lldb-commits] [PATCH] D22628: Fixing layout of elf-core file related structures

2016-07-21 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 64902. dvlahovski added a comment. Forgot to add alignas to two members of prstatus https://reviews.llvm.org/D22628 Files: source/Plugins/Process/elf-core/ThreadElfCore.cpp source/Plugins/Process/elf-core/ThreadElfCore.h Index: source/Plugins/Proces

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-21 Thread Stephane Sezer via lldb-commits
Yeah I can do this today. > On Jul 19, 2016, at 1:58 AM, Zachary Turner wrote: > > I can't test this on Windows until Friday because I'm traveling and my laptop > isn't set up to build lldb. Could Stephane maybe help? > > > On Tue, Jul 19, 2016 at 1:51 AM Saleem Abdulrasool > wrote: > compn

[Lldb-commits] [lldb] r276351 - Stop printing double { characters on Dictionary StructuredData objects

2016-07-21 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jul 21 17:50:01 2016 New Revision: 276351 URL: http://llvm.org/viewvc/llvm-project?rev=276351&view=rev Log: Stop printing double { characters on Dictionary StructuredData objects when Dumping, thanks to Devin to catching the edit mistake I made in r276079. Modified:

[Lldb-commits] [lldb] r276369 - Add support to get the shared cache information from the new

2016-07-21 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jul 21 19:17:55 2016 New Revision: 276369 URL: http://llvm.org/viewvc/llvm-project?rev=276369&view=rev Log: Add support to get the shared cache information from the new debugserver jGetSharedCacheInfo packet instead of reading the dyld internal data structures directly.