tfiala added a comment.
> ! In https://reviews.llvm.org/D22213#481728, @labath wrote:
> I don't remember seeing any changes here so it's quite possible it never
> worked in the first place, but I have no idea what could be different about
> my setup.
I'll have to have a look at it. Thanks f
Author: hhellyer
Date: Mon Jul 18 03:25:59 2016
New Revision: 275778
URL: http://llvm.org/viewvc/llvm-project?rev=275778&view=rev
Log:
Implement GetMemoryRegions() for Windows Minidumps and live processes.
Summary:
This patch fills in the implementation of GetMemoryRegions() on the Windows
live
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
We've had two copies of code for launching processes:
- one in NativeProcessLinux, used for launching debugged processes
- one in
Author: labath
Date: Mon Jul 18 06:27:19 2016
New Revision: 275782
URL: http://llvm.org/viewvc/llvm-project?rev=275782&view=rev
Log:
[test] Report error when inferior test processes exit with a non-zero code
Summary:
We've run into this problem when the test errored out so early (because it
coul
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275782: [test] Report error when inferior test processes
exit with a non-zero code (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D22404?vs=64115&id=64297#toc
https://reviews.l
labath added a comment.
I have now :)
https://reviews.llvm.org/D22404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: nitesh.jain
Date: Mon Jul 18 07:37:44 2016
New Revision: 275785
URL: http://llvm.org/viewvc/llvm-project?rev=275785&view=rev
Log:
[LLVM][MIPS] Revert support for FRE.
Reviewers: jaydeep
Subscribers: bhushan, mohit.bhakkad, slthakur, llvm-commits
Modified:
lldb/trunk/source/Plugins/
Author: labath
Date: Mon Jul 18 09:42:01 2016
New Revision: 275791
URL: http://llvm.org/viewvc/llvm-project?rev=275791&view=rev
Log:
Revert "[test] Report error when inferior test processes exit with a non-zero
code"
This reverts r275782.
The problem with the commit is that it reports an additi
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:129
@@ +128,3 @@
+* The linear history can still be accessed in the (RO) submodule meta project,
+ Which will continue to have SVN access.
+
compnerd wrote:
> "Which will continue to have SVN a
compnerd added inline comments.
Comment at: docs/Proposals/GitHub.rst:167
@@ +166,3 @@
+with the limited number of developers whose job will be to mainly merge
+thousands of patches a day.
+
rengolin wrote:
> compnerd wrote:
> > I don't fully understand how this i
rengolin removed rL LLVM as the repository for this revision.
rengolin updated this revision to Diff 64334.
rengolin added a comment.
First round of changes reflecting reviews.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
=
filcab added a subscriber: filcab.
filcab added a comment.
What about branches? I'm guessing we should expect the usual release branches.
But will any person be able to create a branch? Will there be a policy, if this
is the case? Is the policy enforceable?
Comment at: docs/Pr
emaste added a subscriber: emaste.
Comment at: docs/Proposals/GitHub.rst:8-9
@@ +7,4 @@
+
+This is a proposal to move our current revision control system from Subversion
+to GitHub. Below are the financial and technical arguments as to why we need
+such a move and how will people
Author: tfiala
Date: Mon Jul 18 14:15:38 2016
New Revision: 275885
URL: http://llvm.org/viewvc/llvm-project?rev=275885&view=rev
Log:
make macOS 'launch in terminal' bring terminal to the front during launch
rdar://25235812
Modified:
lldb/trunk/source/Host/macosx/Host.mm
Modified: lldb/trunk
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:8-9
@@ +7,4 @@
+
+This is a proposal to move our current revision control system from Subversion
+to GitHub. Below are the financial and technical arguments as to why we need
+such a move and how will people (an
rengolin updated this revision to Diff 64371.
rengolin added a comment.
Second round of suggestions applied.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
===
--- /dev/null
+++
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:198
@@ +197,3 @@
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account.
+4. Make sure bisecting with llvm-project works.
mehdi_amini wrote:
> Uh, this point i
rengolin updated this revision to Diff 64373.
rengolin added a comment.
Removing "broken" to describe the history, just explaining it'll be local.
Expanding to mention that hooks will need to be implemented in step 3.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: d
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:200
@@ +199,3 @@
+
+Here's a proposed plan:
+
You can click on the "<<" button and it will show where it was first inserted.
That's how I found out. :)
The hooks, AFAICS, will be added to the
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:208
@@ +207,3 @@
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history, update, merges).
+4. Make sure bisecting with llvm-project works.
--
Author: chaoren
Date: Mon Jul 18 16:11:43 2016
New Revision: 275914
URL: http://llvm.org/viewvc/llvm-project?rev=275914&view=rev
Log:
Add missing headers after header cleanup in r275882.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
Modified:
lldb/tru
rengolin updated this revision to Diff 64383.
rengolin added a comment.
Expand step 2 to make sure we don't forget about the safety hooks on each
project as well as the webhook to update the umbrella project. This could turn
out to be a buildbot, but makes no difference at this stage.
https://
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history, up
jyknight added a subscriber: jyknight.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (hist
compnerd added a comment.
Ugh, yeah, I had forgotten about this. Ill try to get to this tonight/tomorrow.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:354-355
@@ -358,5 +353,4 @@
{
-// Calculate absolute timeout value
-TimeValue timeout = Ti
compnerd added a comment.
*hadn't
Repository:
rL LLVM
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Mon Jul 18 21:37:07 2016
New Revision: 275944
URL: http://llvm.org/viewvc/llvm-project?rev=275944&view=rev
Log:
Ignore clang-module-cache directories that may be created
in the testsuite directory while it runs.
Modified:
lldb/trunk/.gitignore
Modified: lldb/trunk/.git
ebtaleb added a comment.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4315
@@ +4314,3 @@
+if (die.GetLanguage() ==
lldb::eLanguageTypeOCaml) {
+location.SetLocationListSlide(0);
+
jroelofs added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
rengolin created this revision.
rengolin added reviewers: lattner, chandlerc, jyknight, mehdi_amini, MatzeB,
probinson, t.p.northover, chapuni, delcypher, dberlin, rsmith, beanz,
cmatthews, asl, aaron.ballman, bcraig, Bigcheese, jroelofs, theraven, greened,
hong.gyu.kim, rafael, AlexDenisov, sil
delcypher added a subscriber: delcypher.
Comment at: docs/Proposals/GitHub.rst:102
@@ +101,3 @@
+
+How will the new workflow look like
+===
s/How will/What will/
Comment at: docs/Proposals/GitHub.rst:136
@@ +135,3
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history,
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:208
@@ +207,3 @@
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history, update, merges).
+4. Make sure bisecting with llvm-project works.
winksaville added a subscriber: winksaville.
Comment at: docs/Proposals/GitHub.rst:132
@@ +131,3 @@
+
+There is no need to additional tags, flags and properties, nor of external
+services controlling the history, since both SVN and *git rev-list* can already
This
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
jroelofs added a subscriber: jroelofs.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can s
probinson added a subscriber: probinson.
Comment at: docs/Proposals/GitHub.rst:141
@@ +140,3 @@
+has commit access to our current repository. In the future, you only need to
+provide the GitHub user to be granted access.
+
This reads a little bit like "we will cre
compnerd added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
mehdi_amini added a subscriber: mehdi_amini.
Comment at: docs/Proposals/GitHub.rst:122
@@ +121,3 @@
+of understanding the *sequence* in which commits were added by using the
+``git rev-list --count hash`` or ``git describe hash`` commands.
+
filcab wrote:
> How ea
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history,
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:199
@@ +198,3 @@
+
+Here's a proposed plan:
+
Annoyingly my comment does no longer show-up next to the point it was referring
to, it was about your third point:
> Make sure we have an llvm-
vsk added subscribers: friss, vsk.
vsk added a comment.
@rengolin thanks for putting this together! I chimed in with some comments
in-line.
Comment at: docs/Proposals/GitHub.rst:68
@@ +67,3 @@
+ * Collaborate with peers directly, even without access to the Internet
+ * Have mul
>> Can't handle the update of the umbrella *because of GitHub*, this could be
>> possible with our own hosting of git for instance.
>>
> Pre-commit hooks are not designed to update the umbrella. Webhooks will be
> able to update the umbrella with a small external service, as proposed in the
> IR
friss added inline comments.
Comment at: docs/Proposals/GitHub.rst:220
@@ +219,3 @@
+8. Tell people living downstream to pick up commits from the official git
+ repository.
+9. Give things time to settle. We could play some games like disabling the SVN
vsk wrote
dberris added a subscriber: dberris.
dberris added a comment.
Mostly wording comments, thank you for writing this up!
Comment at: docs/Proposals/GitHub.rst:78
@@ +77,3 @@
+
+GitHub, like GitLab and BitBucket, provide FREE code hosting for open source
+projects. Essentially, they
> On Jul 18, 2016, at 8:23 PM, Tim Northover via cfe-commits
> wrote:
>
>>> Can't handle the update of the umbrella *because of GitHub*, this could be
>>> possible with our own hosting of git for instance.
>>>
>> Pre-commit hooks are not designed to update the umbrella. Webhooks will be
>> a
compnerd added a comment.
Tested against Linux-x86_64, tests state seems unchanged across the patch.
@zturner you want to run another round on Windows before I merge this?
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@
48 matches
Mail list logo
