Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

hhellyer added inline comments. Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338 @@ -315,4 +337,3 @@ // truncated. -error.SetErrorString("address is not in a known range"); return error; } amccarth wrote: > hhellyer wro

Re: [Lldb-commits] [PATCH] D22357: [NPL] Simplify process launch code

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good https://reviews.llvm.org/D22357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

labath created this revision. labath added reviewers: tfiala, zturner. labath added a subscriber: lldb-commits. We've run into this problem when the test errored out so early (because it could not connect to the remote device), that the code in D20193 did not catch the error. This resulted in th

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

labath added a comment. I think this also makes the code in https://reviews.llvm.org/D20193 obsolete. If this goes in, I can create a follow-up to remove that. https://reviews.llvm.org/D22404 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] r275544 - [NPL] Simplify process launch code

Author: labath Date: Fri Jul 15 05:18:15 2016 New Revision: 275544 URL: http://llvm.org/viewvc/llvm-project?rev=275544&view=rev Log: [NPL] Simplify process launch code Summary: This removes one level of indirection, which was just packing and repacking launch args into different structures. NFC.

Re: [Lldb-commits] [PATCH] D22357: [NPL] Simplify process launch code

This revision was automatically updated to reflect the committed changes. Closed by commit rL275544: [NPL] Simplify process launch code (authored by labath). Changed prior to commit: https://reviews.llvm.org/D22357?vs=63973&id=64118#toc Repository: rL LLVM https://reviews.llvm.org/D22357 F

[Lldb-commits] [lldb] r275555 - Fix TestDarwinNSLogOutput for windows

Author: labath Date: Fri Jul 15 07:19:28 2016 New Revision: 27 URL: http://llvm.org/viewvc/llvm-project?rev=27&view=rev Log: Fix TestDarwinNSLogOutput for windows pexpect python package does not exist on windows Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/nslog/TestDa

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

It's useful to have more descriptive error messages about why a test failed though. Saying that a test returned exit code 1 is worse than saying it had a bad decorator invocation On Fri, Jul 15, 2016 at 3:12 AM Pavel Labath wrote: > labath added a comment. > > I think this also makes the code in

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

labath added a comment. I don't think the original version tried to make a nice error message. It got flagged as an error, and that was it. Now it will get flagged as exceptional exit. In any case we will print out the stderr/stdout (I changed this from stderr-only, because in my case the only

Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

amccarth accepted this revision. amccarth added a reviewer: amccarth. amccarth added a comment. LGTM. Thanks! Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338 @@ -315,4 +337,3 @@ // truncated. -error.SetErrorString("address is not in a kno

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks fine here. Did either of you try this with an exceptional exit to make sure that still shows up right? https://reviews.llvm.org/D22404 __

Re: [Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL275641: Fixes for standalone build: (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D22322?vs=64000&id=64206#toc Repository: rL LLVM https://reviews.llvm.org/D22322 F

[Lldb-commits] [lldb] r275641 - Fixes for standalone build:

Author: eugenezelenko Date: Fri Jul 15 17:46:15 2016 New Revision: 275641 URL: http://llvm.org/viewvc/llvm-project?rev=275641&view=rev Log: Fixes for standalone build: * include CheckAtomic to set HAVE_CXX_ATOMICS64_WITHOUT_LIB properly (introduced in r274121) * hint Clang CMake files for LLVM C

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to try to commit these changes before 3.9 branching. Repository: rL LLVM https://reviews.llvm.org/D20436 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] r275652 - Fixed the location of the Swift bindings in the Xcode build.

Author: spyffe Date: Fri Jul 15 19:18:24 2016 New Revision: 275652 URL: http://llvm.org/viewvc/llvm-project?rev=275652&view=rev Log: Fixed the location of the Swift bindings in the Xcode build. $BUILT_PRODUCTS_DIR is usually the same as $CONFIGURATION_BUILD_DIR, but differs when LLDB is being bui