[Lldb-commits] [lldb] r273546 - Test commit to verify access, fix typo.

2016-06-23 Thread Howard Hellyer via lldb-commits
Author: hhellyer Date: Thu Jun 23 03:31:22 2016 New Revision: 273546 URL: http://llvm.org/viewvc/llvm-project?rev=273546&view=rev Log: Test commit to verify access, fix typo. Modified: lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.h Modified: lldb/trunk/source/Plugins/Process/m

[Lldb-commits] [lldb] r273547 - Add MemoryRegionInfo to SB API

2016-06-23 Thread Howard Hellyer via lldb-commits
Author: hhellyer Date: Thu Jun 23 03:35:37 2016 New Revision: 273547 URL: http://llvm.org/viewvc/llvm-project?rev=273547&view=rev Log: Add MemoryRegionInfo to SB API Summary: This adds new SB API calls and classes to allow a user of the SB API to obtain a full list of memory regions accessible w

Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

2016-06-23 Thread Howard Hellyer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273547: Add MemoryRegionInfo to SB API (authored by hhellyer). Changed prior to commit: http://reviews.llvm.org/D20565?vs=61253&id=61648#toc Repository: rL LLVM http://reviews.llvm.org/D20565 Files

Re: [Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-23 Thread Simon Dardis via lldb-commits
sdardis added a comment. You also need to emulate dsubu and subu as the MIPS LLVM backend will generate them in certain cases. Repository: rL LLVM http://reviews.llvm.org/D21064 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://li

Re: [Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-23 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In http://reviews.llvm.org/D21064#465410, @sdardis wrote: > You also need to emulate dsubu and subu as the MIPS LLVM backend will > generate them in certain cases. Thanks will emulate them too. Repository: rL LLVM http://reviews.llvm.org/D21064

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-23 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 61668. ravitheja added a comment. Adding testcase http://reviews.llvm.org/D21221 Files: packages/Python/lldbsuite/test/functionalities/unwind/nonabi/ packages/Python/lldbsuite/test/functionalities/unwind/nonabi/Makefile packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, tfiala, zturner. fjricci added subscribers: lldb-commits, sas. When running the test suite in platform mode, this test would use 'platform select host', which would cause the rest of the suite to stop running in platform mode. Ins

[Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, jingham, vharron. fjricci added subscribers: sas, lldb-commits. When using 'platform select', re-use an existing platform which matches the remote platform specs, rather than creating a new one. Without this patch, repeating the fo

[Lldb-commits] [lldb] r273582 - fix Xcode build for r273547

2016-06-23 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Jun 23 11:54:39 2016 New Revision: 273582 URL: http://llvm.org/viewvc/llvm-project?rev=273582&view=rev Log: fix Xcode build for r273547 Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/viewv

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit

2016-06-23 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So this is close. My idea was that the lldb-server would not just set a key/value pair named "dynamic_size" to "1" in the "qRegisterInfo" or "$qXfer:features:read:target.xml:0,1f

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci planned changes to this revision. fjricci added a comment. This will fail in the case where the remote-platform server dies, as lldb will not cleanup its data structures. I'll investigate how to make sure the platform is alive before connecting to it. http://reviews.llvm.org/D21649

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. Make sure you keep a very close eye on all the buildbots with this one. I agree this change is good, but I seem to remember there were problems when this was done. http://reviews.llvm.org/D21649 _

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. Sorry missed your comments about when a platform dies. Also be sure to know that you might not have to connect to a platform for it to be useful. We have ios-simulator platforms that don't require connecting. http://reviews

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci added a comment. As I'm poking through the APIs, I found that platform_sp->IsConnected() will return true even if the remote server has been killed since connecting (at least on remote-linux with lldb-server in platform mode). Is this the expected behavior of that set of functions? ht

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci added a comment. Although, given your comments about the ios platforms, IsConnected() doesn't seem like the right API to use anyway... http://reviews.llvm.org/D21649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [lldb] r273604 - Added a new python example which installs a command called "shadow".

2016-06-23 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Jun 23 14:54:32 2016 New Revision: 273604 URL: http://llvm.org/viewvc/llvm-project?rev=273604&view=rev Log: Added a new python example which installs a command called "shadow". This shows how to grab individual blocks from stack frames and get only the variables from

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci abandoned this revision. fjricci added a comment. I don't think that we can assume that the user always wants to re-use an existing platform, even of the same type. Probably the only way to resolve the problem this tries to fix would be to add a command to display all connected platform

Re: [Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci planned changes to this revision. fjricci added a comment. This fix does not work without something along the lines of http://reviews.llvm.org/D21649, I'll re-upload with a better fix. http://reviews.llvm.org/D21648 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 61717. fjricci added a comment. This revision is now accepted and ready to land. Disconnect from existing platform connection to prevent extra hanging connections This is good practice on all debug servers, and required for debug servers which can't handle m

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Greg Clayton via lldb-commits
clayborg added a comment. Platforms are funny because the "ios-simulator" platform doesn't need to be connected for anything since it exists and runs things locally. The platform is there to help us launch our processes so they run as simulator binaries, and also to help locate files and other

Re: [Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

2016-06-23 Thread Todd Fiala via lldb-commits
tfiala added a comment. Hi all, If memory serves me correctly, I originally wrote this test. I don't think it buys us anything to run it against remote targets. I think a better approach here is to just exclude it when running against a remote. We could instead use: @decorator.skipIfRemot

[Lldb-commits] [lldb] r273622 - Don't run the top-level expression test case with -gmodules.

2016-06-23 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 23 17:18:08 2016 New Revision: 273622 URL: http://llvm.org/viewvc/llvm-project?rev=273622&view=rev Log: Don't run the top-level expression test case with -gmodules. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExp

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Ted Woodward via lldb-commits
ted added a subscriber: ted. ted added a comment. The Hexagon platform (currently in-house only) acts like the ios simulator platform, in that it doesn't connect - it fixes up the command line, then launches the Hexagon simulator (based on the debugserver launch code in the gdb-remote process p

Re: [Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci added a comment. I was wondering that as well. I thought there might be some value to testing that the "disconnect->change platform->reconnect" path worked though. I have no problem disabling if that doesn't seem useful though. http://reviews.llvm.org/D21648

[Lldb-commits] [lldb] r273632 - Handle variadic Objective-C methods from DWARF correctly.

2016-06-23 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 23 19:24:40 2016 New Revision: 273632 URL: http://llvm.org/viewvc/llvm-project?rev=273632&view=rev Log: Handle variadic Objective-C methods from DWARF correctly. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/variadic_methods/ lldb/trunk/package

[Lldb-commits] Fwd: Buildbot numbers for the last week of 6/12/2016 - 6/18/2016

2016-06-23 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 6/12/2016 - 6/18/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

2016-06-23 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D21648#466011, @fjricci wrote: > I was wondering that as well. I thought there might be some value to testing > that the "disconnect->change platform->reconnect" path worked though. I have > no problem disabling if that doesn't seem useful thou

Re: [Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

2016-06-23 Thread Francis Ricci via lldb-commits
fjricci planned changes to this revision. fjricci added a comment. That's reasonable, will do. http://reviews.llvm.org/D21648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r273640 - Fix an issue where the @lldb.command marker would not work with the new 5-argument version of the Python command function

2016-06-23 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jun 23 21:07:15 2016 New Revision: 273640 URL: http://llvm.org/viewvc/llvm-project?rev=273640&view=rev Log: Fix an issue where the @lldb.command marker would not work with the new 5-argument version of the Python command function This: a) teaches PythonCallable to look i

[Lldb-commits] [lldb] r273648 - Update LLDB for r273647

2016-06-23 Thread David Majnemer via lldb-commits
Author: majnemer Date: Thu Jun 23 23:39:22 2016 New Revision: 273648 URL: http://llvm.org/viewvc/llvm-project?rev=273648&view=rev Log: Update LLDB for r273647 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL: http://llvm.org/v

[Lldb-commits] [lldb] r273649 - Silence a -Wc++11-narrowing warning

2016-06-23 Thread David Majnemer via lldb-commits
Author: majnemer Date: Fri Jun 24 00:31:23 2016 New Revision: 273649 URL: http://llvm.org/viewvc/llvm-project?rev=273649&view=rev Log: Silence a -Wc++11-narrowing warning Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL: http: