Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

2016-06-20 Thread Howard Hellyer via lldb-commits
hhellyer marked 12 inline comments as done. hhellyer added a comment. http://reviews.llvm.org/D20565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

2016-06-20 Thread Howard Hellyer via lldb-commits
hhellyer updated this revision to Diff 61253. hhellyer added a comment. Updating to ensure I have the latest changes. http://reviews.llvm.org/D20565 Files: include/lldb/API/LLDB.h include/lldb/API/SBDefines.h include/lldb/API/SBMemoryRegionInfo.h include/lldb/API/SBMemoryRegionInfoList.

Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

2016-06-20 Thread Howard Hellyer via lldb-commits
hhellyer added a comment. I re-updated the patch via arc diff (rather than a manual patch upload). Phabricator now seems to know which revision my changes are based off and has added the "Next Step: arc commit" status. Do I need to request an svn password to run arc commit or can you (or someon

Re: [Lldb-commits] [PATCH] D21516: Allow unaligned byte/word selection watchpoints for arm- linux/android targets.

2016-06-20 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D21516 ___ lldb-commits mailing list lldb-commits@lists.l

Re: [Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

2016-06-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Seems like CheckIfWatchpointsExhausted() inside Target.cpp works for some targets, but not all of them. Seems like this functionality should be pushed down into RegisterContext to do this

[Lldb-commits] [lldb] r273211 - Test that lldb calls the right 'printf' even when a 'printf' method exists.

2016-06-20 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Jun 20 18:01:11 2016 New Revision: 273211 URL: http://llvm.org/viewvc/llvm-project?rev=273211&view=rev Log: Test that lldb calls the right 'printf' even when a 'printf' method exists. This test is currently failing. We have a bug for it, as noted. Added: lldb/trunk/

Re: [Lldb-commits] [PATCH] D21422: Fix typo in eOpenOptionDontFollowSymlinks

2016-06-20 Thread Francis Ricci via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273225: Fix typo in eOpenOptionDontFollowSymlinks (authored by fjricci). Changed prior to commit: http://reviews.llvm.org/D21422?vs=60937&id=61325#toc Repository: rL LLVM http://reviews.llvm.org/D21

[Lldb-commits] [lldb] r273225 - Fix typo in eOpenOptionDontFollowSymlinks

2016-06-20 Thread Francis Ricci via lldb-commits
Author: fjricci Date: Mon Jun 20 19:03:57 2016 New Revision: 273225 URL: http://llvm.org/viewvc/llvm-project?rev=273225&view=rev Log: Fix typo in eOpenOptionDontFollowSymlinks Summary: Fix capitalization Reviewers: labath, sas, clayborg Subscribers: lldb-commits Differential Revision: http://r

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-20 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. Jason Molenda should be able to adequately review any patches. If he is OK, then I am OK. http://reviews.llvm.org/D21221 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D21328: [lldb] Fixed incorrect endianness when evaluating certain expressions

2016-06-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sean Callanan needs to OK this as well. http://reviews.llvm.org/D21328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

2016-06-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I am OK if Sean is OK with this. http://reviews.llvm.org/D17856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.o

[Lldb-commits] [lldb] r273236 - Change the "debugserver-mini" target (a version of debugserver

2016-06-20 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 20 22:39:39 2016 New Revision: 273236 URL: http://llvm.org/viewvc/llvm-project?rev=273236&view=rev Log: Change the "debugserver-mini" target (a version of debugserver which doesn't like against all the extra UI frameworks on ios) so it now generates a binary called "