labath accepted this revision.
labath added a comment.
Seems to run fine on linux now. Thanks for investigating this. We'll monitor
the buildbots and let you know if anything bad happens. ;)
BTW. your comment in ControlPrivateStateThread seems to indicate that the linux
behavior is inconsistent
ravitheja added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1602
@@ -1610,3 +1601,3 @@
// isn't going to do any better.
-if (m_full_unwind_plan_sp->GetSourcedFromCompiler() == eLazyBoolYes)
-return false;
+//if (m_full_u
ravitheja added a comment.
so regarding this particular situation I want to give little more insight ->
It starts out from here
0x40143a <+346>: movabsq $0x403e32, %rdi ; imm = 0x403E32
0x401444 <+356>: movb $0x0, %al
0x401446 <+358>: callq 0x400d30 ; symbol s
ravitheja added a comment.
@labath In order to reproduce this situation without the help of standard
library, I would have to write handwritten assembly and the CFI directives for
that, is that fine ?
http://reviews.llvm.org/D21221
___
lldb-commit
labath added a comment.
In http://reviews.llvm.org/D21221#457329, @ravitheja wrote:
> @labath In order to reproduce this situation without the help of standard
> library, I would have to write handwritten assembly and the CFI directives
> for that, is that fine ?
Yes, I think that's fine. Obv
hhellyer added a comment.
Should I be able to deliver these changes now? When I try following the
instructions here: http://llvm.org/docs/Phabricator.html the patch
downloads and applies correctly but whether I use arc via the git or svn
commit methods I'm ultimately prompted for a password fo
labath created this revision.
labath added a reviewer: tberghammer.
labath added subscribers: lldb-commits, omjavaid, nitesh.jain, uweigand.
This removes the last usage of the Platform plugin in NPL. It was being
used for determining the architecture of the debugged process. I replace
the call tha
labath abandoned this revision.
labath added a comment.
I am abandoning this in favor of http://reviews.llvm.org/D21324, which achieves
the same result (no Platform plugin), but still uses the elf-parsing method to
keep everything working as is now.
You can give it a try if you want, but I don'
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D21324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
cameron314 added a comment.
Thanks everyone :-)
Ah, yeah, sorry if I gave the wrong impression, but that comment is not
specific to Linux (in fact, I've only seen it once, on Windows). At one point
the debugger had entered ControlPrivateStateThread on one thread to stop it,
seen that the threa
Author: cameron314
Date: Tue Jun 14 11:22:45 2016
New Revision: 272682
URL: http://llvm.org/viewvc/llvm-project?rev=272682&view=rev
Log:
[lldb] Fixed race conditions on private state thread exit
This patch fixes various races between the time the private state thread is
signaled to exit and the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272682: [lldb] Fixed race conditions on private state thread
exit (authored by cameron314).
Changed prior to commit:
http://reviews.llvm.org/D21296?vs=60536&id=60693#toc
Repository:
rL LLVM
http://r
cameron314 created this revision.
cameron314 added reviewers: spyffe, zturner, clayborg.
cameron314 added a subscriber: lldb-commits.
The `EntityVariable` materializer was, under certain conditions, taking the
bytes of a `DataExtractor` that were potentially in host order (e.g. little
endian) an
Author: labath
Date: Tue Jun 14 12:30:52 2016
New Revision: 272686
URL: http://llvm.org/viewvc/llvm-project?rev=272686&view=rev
Log:
Remove Platform usages from NativeProcessLinux
Summary:
This removes the last usage of the Platform plugin in NPL. It was being
used for determining the architectur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272686: Remove Platform usages from NativeProcessLinux
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D21324?vs=60679&id=60705#toc
Repository:
rL LLVM
http://reviews.llvm.org
OK, i see. Thanks for the explanation. This may actually be some
windows specific thing then, as I remember zachary mentioning they
have some flakyness issues there.
BTW, this has sped up the LLDB test suite nearly 2x, so thanks a lot
for that. :)
pl
On 14 June 2016 at 17:13, Cameron wrote:
>
labath added a subscriber: labath.
labath added a comment.
OK, i see. Thanks for the explanation. This may actually be some
windows specific thing then, as I remember zachary mentioning they
have some flakyness issues there.
BTW, this has sped up the LLDB test suite nearly 2x, so thanks a lot
for
Hello everyone,
LLVM buildmaster will be restarted after 8 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hello everyone,
Below are some buildbot numbers for the last week of 6/05/2016 - 6/11/2016.
Thanks
Galina
buildername | was_red
---+---
sanitizer-x86_64-linux-bootstrap
jasonmolenda added a comment.
Thanks Ravi, I see the problem here and I agree that lldb should use eh_frame
to unwind from this function - that's the only way this is going to work. I'm
surprised that there is accurate eh_frame instructions for this function, it's
great to see it.
I'm wonderi
Some of these tables are getting quite mangled somewhere along the line
(email client? mailing list handling? idk). Could you re-send with the
tables also attached or something else that avoids that problem?
-- Sean Silva
On Tue, Jun 14, 2016 at 4:23 PM, Galina Kistanova via cfe-commits <
cfe-co
Author: penryu
Date: Tue Jun 14 22:53:21 2016
New Revision: 272751
URL: http://llvm.org/viewvc/llvm-project?rev=272751&view=rev
Log:
Add results.xml for macOS lldb unittests
http://reviews.llvm.org/D21211
If gtest tests of lldb fail, there are no test results for Jenkins to
consume. This will ma
22 matches
Mail list logo
