Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

2016-06-03 Thread Howard Hellyer via lldb-commits
hhellyer updated this revision to Diff 59524. hhellyer marked an inline comment as done. hhellyer added a comment. Fix the latest code review comments to remove unnecessary tests for a valid pointer that will always be initialised. The change to the == operator on SBMemoryRegionInfo required an

Re: [Lldb-commits] [PATCH] D16237: Fixes to ensure TestLogging.py tests work with Python 3.5 as well as 2.7.

2016-06-03 Thread Adrian McCarthy via lldb-commits
amccarth abandoned this revision. amccarth added a comment. This was committed a while back. http://reviews.llvm.org/D16237 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16476: XFail TestNamespaceLookup on Windows.

2016-06-03 Thread Adrian McCarthy via lldb-commits
amccarth abandoned this revision. amccarth added a comment. Already committed. http://reviews.llvm.org/D16476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-06-03 Thread Luke Drummond via lldb-commits
ldrumm added a comment. I'd like to give this another *bump*, and commit this soon assuming positive review. @spyffe http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] r271696 - Add support in debug LLDB builds (if LLDB_CONFIGURATION_DEBUG is defined) where we can set an environment variable named LLDB_DWARF_DONT_COMPLETE_TYPENAMES that can con

2016-06-03 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jun 3 12:59:26 2016 New Revision: 271696 URL: http://llvm.org/viewvc/llvm-project?rev=271696&view=rev Log: Add support in debug LLDB builds (if LLDB_CONFIGURATION_DEBUG is defined) where we can set an environment variable named LLDB_DWARF_DONT_COMPLETE_TYPENAMES that

[Lldb-commits] [lldb] r271716 - Fix a printf warning.

2016-06-03 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jun 3 14:45:05 2016 New Revision: 271716 URL: http://llvm.org/viewvc/llvm-project?rev=271716&view=rev Log: Fix a printf warning. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWAR

[Lldb-commits] [PATCH] D20990: Don't remove PIE executables when using svr4 packets

2016-06-03 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, ADodds, tfiala. fjricci added a subscriber: lldb-commits. Because PIE executables have an e_type of llvm::ELF::ET_DYN, they are not of type eTypeExecutable, and were being removed when svr4 packets were used. http://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D20990: Don't remove PIE executables when using svr4 packets

2016-06-03 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 59633. fjricci added a comment. Fix curly-brace style http://reviews.llvm.org/D20990 Files: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp =

Re: [Lldb-commits] [PATCH] D20990: Don't remove PIE executables when using svr4 packets

2016-06-03 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 59637. fjricci added a comment. Refactor to remove unnecessary object file type checking http://reviews.llvm.org/D20990 Files: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp ==

[Lldb-commits] [lldb] r271774 - Add armv7 compact unwind printing to the compact-unwind-dumper.c tool

2016-06-03 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jun 3 23:10:15 2016 New Revision: 271774 URL: http://llvm.org/viewvc/llvm-project?rev=271774&view=rev Log: Add armv7 compact unwind printing to the compact-unwind-dumper.c tool as a prototype for adding armv7 compact unwind reading to lldb. Modified: lldb/trunk/too