Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

hhellyer updated this revision to Diff 59205. hhellyer added a comment. I've switch to a unique_ptr from a shared_ptr in SBMemoryRegionInfo. http://reviews.llvm.org/D20565 Files: include/lldb/API/LLDB.h include/lldb/API/SBDefines.h include/lldb/API/SBMemoryRegionInfo.h include/lldb/API/

Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

hhellyer added a comment. In http://reviews.llvm.org/D20565#444507, @clayborg wrote: > My main reason for making sure we use std::unique_ptr is for API > compatibility in the future. The size of std::unique_ptr and std::shared_ptr > differs and if anyone wrote an IDE or tool that links against

Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. One last thing: we should default construct a MemoryRegionInfo in all SBMemoryRegionInfo::SBMemoryRegionInfo() constructors so we don't have a make sure to call a non-const ref()

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

aprantl updated this revision to Diff 59264. aprantl added a comment. I have one last question: While trying to add a testcase I noticed that DisplaySourceLinesWithLineNumbers is still exported into Python with the old signature. What is the correct way to update the Python bindings? http://re

[Lldb-commits] [PATCH] D20875: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.

andrewford created this revision. andrewford added reviewers: clayborg, tberghammer. andrewford added a subscriber: lldb-commits. Fix missing return after checking that m_backend is not a pointer or reference type. http://reviews.llvm.org/D20875 Files: source/Plugins/Language/Java/JavaFormatt

Re: [Lldb-commits] [PATCH] D20875: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good, thanks for fixing it (I seen strange issues caused by this so it will help a lot). http://reviews.llvm.org/D20875 ___ lldb

[Lldb-commits] [lldb] r271433 - [tsan] Prefer mangled name looking up variable declaration for racy address

Author: dcoughlin Date: Wed Jun 1 16:32:45 2016 New Revision: 271433 URL: http://llvm.org/viewvc/llvm-project?rev=271433&view=rev Log: [tsan] Prefer mangled name looking up variable declaration for racy address For Thread Sanitizer reports, LLDB tries to find a global variable declaration corres

Re: [Lldb-commits] [PATCH] D20760: [tsan] Prefer mangled name when looking up global variable declaration for racy address

This revision was automatically updated to reflect the committed changes. Closed by commit rL271433: [tsan] Prefer mangled name looking up variable declaration for racy address (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D20760?vs=58862&id=59280#toc Repository:

[Lldb-commits] [lldb] r271453 - Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.

Author: tberghammer Date: Wed Jun 1 19:45:38 2016 New Revision: 271453 URL: http://llvm.org/viewvc/llvm-project?rev=271453&view=rev Log: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject. Summary: Fix missing return after checking that m_backend is not a pointer or reference type. R

Re: [Lldb-commits] [PATCH] D20875: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271453: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject. (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D20875?vs=59265&id=59321#toc Repository: rL LLVM htt