hhellyer updated this revision to Diff 58771.
hhellyer added a comment.
Removed std::enable_shared_from_this from MemoryRegionInfo.h (which removes the
only change from that file)
Renamed region_info to region_info_sp in SBProcess::GetMemoryRegionInfo in
SBProcess.cpp
I also corrected the positi
What was the issue?
On Wed, May 25, 2016 at 12:17 PM, Galina Kistanova via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> Hello,
>
> Builder
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
> is back to normal.
> Sorry for the noise.
>
> Thanks
>
> Galina
tfiala added a comment.
This was the logging I used to discover the breakage in launching debugserver
from 'lldb-server platform' on Apple platforms.
http://reviews.llvm.org/D20722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This looks good as long as SBMemoryRegionInfo and SBMemoryRegionInfoList are
ready only and will never have any setter functions. If we plan to ever have
the SBMemoryRegionInfo o
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: include/lldb/Interpreter/Args.h:120
@@ -100,3 +119,3 @@
void
-Dump (Stream *s);
+Dump (Stream *s, const char *labe
ovyalov added a comment.
In http://reviews.llvm.org/D16861#441964, @tfiala wrote:
> This change broke connection to debugserver on OS X - the constructed URL on
> debugserver does not take the tcp:// (URL-scheme) portion. This would
> manifest when 'lldb-server platform' was attempting to laun
tfiala added inline comments.
Comment at: include/lldb/Interpreter/Args.h:120
@@ -100,3 +119,3 @@
void
-Dump (Stream *s);
+Dump (Stream *s, const char *label_name) const;
clayborg wrote:
> I would make just one Dump function and default the label_na
tfiala added a comment.
In http://reviews.llvm.org/D16861#442396, @ovyalov wrote:
> In http://reviews.llvm.org/D16861#441964, @tfiala wrote:
>
> > This change broke connection to debugserver on OS X - the constructed URL
> > on debugserver does not take the tcp:// (URL-scheme) portion. This wou
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20760
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
dcoughlin created this revision.
dcoughlin added reviewers: kubabrecka, clayborg.
dcoughlin added a subscriber: lldb-commits.
Herald added a subscriber: kubabrecka.
For Thread Sanitizer reports, LLDB tries to find a global variable declaration
corresponding to the racy address in order to provide
phlav created this revision.
phlav added reviewers: lldb-commits, clayborg.
phlav added a subscriber: phlav.
"ClearDIEs()" was being called too soon, before everyone was done using the
DIEs.
This fix delays the calls to ::ClearDIEs() until all compile units have been
indexed.
1 - Call "::Extra
12 matches
Mail list logo
