This revision was automatically updated to reflect the committed changes.
Closed by commit rL269025: Fix race in TestExitDuringStep and unify
pseudo_barrier handling (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D20065?vs=56567&id=56669#toc
Repository:
rL LLVM
http:
Author: labath
Date: Tue May 10 02:54:25 2016
New Revision: 269025
URL: http://llvm.org/viewvc/llvm-project?rev=269025&view=rev
Log:
Fix race in TestExitDuringStep and unify pseudo_barrier handling
Summary:
TestExitDuringStep was very rarely hanging on the buildbots. I can't be sure,
but I belie
Author: labath
Date: Tue May 10 08:46:22 2016
New Revision: 269057
URL: http://llvm.org/viewvc/llvm-project?rev=269057&view=rev
Log:
Fix SymbolFilePDBTests.cpp
Modified:
lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTest
Author: labath
Date: Tue May 10 08:46:25 2016
New Revision: 269058
URL: http://llvm.org/viewvc/llvm-project?rev=269058&view=rev
Log:
Fix logging in Listener.cpp
Clear() log message was claiming it was the destructor, which had me very
confused when looking
at the log messages. Fix the message, a
labath created this revision.
labath added reviewers: clayborg, zturner, emaste, krytarowski.
labath added a subscriber: lldb-commits.
This replaces the C-style "void *" baton of the child process monitoring
functions with a more
C++-like API taking a std::function. The motivation for this was th
labath created this revision.
labath added a reviewer: clayborg.
labath added subscribers: lldb-commits, tberghammer.
MonitorDebugServerProcess went to a lot of effort to make sure its asynchronous
invocation does
not cause any mischief, but it was still not race-free. Specifically, in a
quick s
labath added a comment.
I am going to try building this on as many systems as I can get my hands on
tomorrow, as I am pretty sure I have missed some changes on host-specific code.
I am posting this here now, to get early feedback and some round-trips.
http://reviews.llvm.org/D20106
labath added a comment.
In http://reviews.llvm.org/D20106#425825, @labath wrote:
> I am going to try building this on as many systems as I can get my hands on
> tomorrow, as I am pretty sure I have missed some changes on host-specific
> code. I am posting this here now, to get early feedback an
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: enrico
Date: Tue May 10 13:16:33 2016
New Revision: 269095
URL: http://llvm.org/viewvc/llvm-project?rev=269095&view=rev
Log:
In some cases, type lookup has to deal with situations where it cannot
reconstruct a compile unit or a function, but it still has a valid symbol - and
it can use t
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just get rid of the extra typedef as specified in inline comments and this is
good to go.
Comment at: include/lldb/Host/HostProcess.h:41
@@ -41,1 +40,3 @@
+publ
It's too bad llvm doesn't have an equivalent of boost::any, because that
would be perfect here :-/
On Tue, May 10, 2016 at 12:39 PM Greg Clayton wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> Just get rid of
emaste added a comment.
Nice.
For test building FreeBSD, snapshot VM images are available at
ftp://ftp.freebsd.org/pub/FreeBSD/snapshots/VM-IMAGES/11.0-CURRENT/amd64/Latest/
and I have some instructions for building lldb on FreeBSD at
https://wiki.freebsd.org/lldb.
http://reviews.llvm.org/D2
On 10 May 2016 at 03:54, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Tue May 10 02:54:25 2016
> New Revision: 269025
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269025&view=rev
> Log:
> Fix race in TestExitDuringStep and unify pseudo_barrier handling
After this change TestT
ted abandoned this revision.
ted added a comment.
Problem will be fixed in another way.
http://reviews.llvm.org/D20035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ted created this revision.
ted added reviewers: jingham, clayborg.
ted added a subscriber: lldb-commits.
The "file" variable in a LineEntry was mapped using target.source-map, except
when stepping through inlined code. This patch adds a new variable to
LineEntry, "original_file", that contains t
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This approach seems right to me.
See the inline comment for BreakpointResolver.
In ThreadPlanStepOverRange at line 235 this instance should also be changed to
original_file:
if
17 matches
Mail list logo
