Re: [Lldb-commits] [Diffusion] rL266139: Fixed being able to set breakpoints on destructors when we don't fully…

tberghammer added subscribers: lldb-commits, tberghammer. /lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:333 I think we don't need the second '~' as now you are accepting things like ``` ~~Foo, ~, ~~ ``` what shouldn't been accepted. I am happy to make the CL for removing it

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

tberghammer accepted this revision. tberghammer added a comment. Looks good http://reviews.llvm.org/D18984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

tberghammer added a subscriber: tberghammer. tberghammer added a comment. My understanding of the eh_frame is that "undefined" means the value of the register is not recoverable in the current frame (default for volatile registers) while the meaning of "same" is that this frame haven't messed wi

[Lldb-commits] [PATCH] D19052: Make destructor breakpoint location test more resilient

labath created this revision. labath added a reviewer: clayborg. labath added subscribers: lldb-commits, zturner, ovyalov. The original breakpoint location test was failing for linux, because the compilers here tend to merge the full-object and subobject destructors even at -O0 (as a result, we

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

abidh added a comment. In http://reviews.llvm.org/D18880#395530, @zturner wrote: > Looks fine to me. TBH I haven't seen any of the lldb-mi owners around in > months, so I'm not sure if they're still active Sorry for late reply. I have been busy lately but keep an eye on lldb-mi patches. ht

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand added a comment. In http://reviews.llvm.org/D18977#399344, @jasonmolenda wrote: > Just to be clear, my concern is we get an register location which is > "undefined" (I've never seen it, I don't know what it means) and now > SavedLocationForRegister() will say "this register is volatile

[Lldb-commits] [lldb] r266192 - Fix test rerun logic

Author: labath Date: Wed Apr 13 07:05:48 2016 New Revision: 266192 URL: http://llvm.org/viewvc/llvm-project?rev=266192&view=rev Log: Fix test rerun logic result_formatter used inspect.getfile() to get the python file name, which returned "*.pyc" if the bytecode file was present. This resulted in

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

labath added a subscriber: labath. labath added a comment. I think having a self-contained test for this issue (one which does not rely on internals of some system library) would be extremely valuable. Could you add one? http://reviews.llvm.org/D18976 ___

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

omjavaid accepted this revision. omjavaid added a comment. LGTM http://reviews.llvm.org/D18984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

uweigand added a comment. In http://reviews.llvm.org/D18976#399633, @labath wrote: > I think having a self-contained test for this issue (one which does not rely > on internals of some system library) would be extremely valuable. Could you > add one? Well, a simple way would be to just add so

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

labath added a comment. I think adding it to the extending the existing test is fine, given that it's a fairly small one. (In case of large tests, it's better to make a new one, so it can be debugged/xfailed independently). Maybe just add `int C` so that we test both the situation when we have

[Lldb-commits] [lldb] r266196 - Remove obsolete comments

Author: labath Date: Wed Apr 13 08:26:45 2016 New Revision: 266196 URL: http://llvm.org/viewvc/llvm-project?rev=266196&view=rev Log: Remove obsolete comments Modified: lldb/trunk/unittests/Host/FileSpecTest.cpp Modified: lldb/trunk/unittests/Host/FileSpecTest.cpp URL: http://llvm.org/viewvc

[Lldb-commits] [lldb] r266197 - Match types in for loop to fix signedness comparison warning

Author: emaste Date: Wed Apr 13 08:32:06 2016 New Revision: 266197 URL: http://llvm.org/viewvc/llvm-project?rev=266197&view=rev Log: Match types in for loop to fix signedness comparison warning Modified: lldb/trunk/source/Symbol/Symtab.cpp Modified: lldb/trunk/source/Symbol/Symtab.cpp URL:

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

uweigand updated this revision to Diff 53553. uweigand added a comment. Add test case. http://reviews.llvm.org/D18976 Files: packages/Python/lldbsuite/test/lang/cpp/scope/TestCppScope.py packages/Python/lldbsuite/test/lang/cpp/scope/main.cpp source/Plugins/ExpressionParser/Clang/ClangExpr

[Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

labath created this revision. labath added a reviewer: zturner. labath added a subscriber: lldb-commits. In D18689, I removed the call to Normalize() in FileSpec::SetFile, because it no longer seemed needed, and it resolved a quirk in the FileSpec API (spec.GetCString() returnes a path with back

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

The expected behavior imo is to normalize before returning in GetDirectory(). Perhaps you could add a boolean with default value true? On Wed, Apr 13, 2016 at 8:26 AM Pavel Labath wrote: > labath created this revision. > labath added a reviewer: zturner. > labath added a subscriber: lldb-commits.

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

labath added a comment. It's a bit more complicated than it seems. GetDirectory() returns a reference into the FileSpec, and a lot of code modifies it through it. Changing that would require fixups in all of the users, which I'd want to do separately. But I do agree that this is the best way fo

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

Ahh that's unfortunate. I guess the thing to do is make SetFile and SetDirectory. At least by changing the return type we can get the compiler to tell us everywhere this is happening. Did you run the test suite on Windows to make sure this doesnt break anything? On Wed, Apr 13, 2016 at 8:36 AM Pave

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

labath added a comment. In http://reviews.llvm.org/D19060#399915, @zturner wrote: > Ahh that's unfortunate. I guess the thing to do is make SetFile and > SetDirectory. At least by changing the return type we can get the compiler > to tell us everywhere this is happening. Did you run the test su

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

Ok sounds good On Wed, Apr 13, 2016 at 9:56 AM Pavel Labath wrote: > labath added a comment. > > In http://reviews.llvm.org/D19060#399915, @zturner wrote: > > > Ahh that's unfortunate. I guess the thing to do is make SetFile and > > SetDirectory. At least by changing the return type we can get t

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good, thanks for updating the changes. http://reviews.llvm.org/D18985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

Re: [Lldb-commits] [PATCH] D19004: Use the section sizes to determine symbols sizes in the Symtab instead of just using the following symbol's address

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM http://reviews.llvm.org/D19004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D19052: Make destructor breakpoint location test more resilient

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D19052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Is the SystemZ ABI not in this patch? Looks good otherwise as long as Jason Molenda is OK with the patch. http://reviews.llvm.org/D18977 ___

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand added a comment. In http://reviews.llvm.org/D18977#400047, @clayborg wrote: > Is the SystemZ ABI not in this patch? Looks good otherwise as long as Jason > Molenda is OK with the patch. The SystemZ ABI is in http://reviews.llvm.org/D18978, which I just re-uploaded. http://reviews.ll

[Lldb-commits] [PATCH] D19067: Make sure to use lib instead of lib64 for LLDB_LIB_DIR

fjricci created this revision. fjricci added reviewers: zturner, vharron, emaste. fjricci added subscribers: sas, lldb-commits. $(lldb -P)/../../ is assumed to be the lldb library directory by the test suite. However, it is possible that the python libs would be installed in build/lib64 instead of

Re: [Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

uweigand updated this revision to Diff 53605. uweigand added a comment. Updated interface documentation in DataExtractor.h. Added unit test case for the DataExtractor::GetMaxU64Bitfield and GetMaxS64Bitfield routines. Retested on System z and Intel. http://reviews.llvm.org/D18982 Files: in

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

jasonmolenda accepted this revision. jasonmolenda added a comment. Hi Tamas & Ulrich. I'm good with this patch, thanks for double checking that detail for me. http://reviews.llvm.org/D18977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

uweigand updated this revision to Diff 53622. uweigand added a comment. This adds some unit tests verifying correct operation of the GetBytes routine as well as the conversions (SChar, UChar, ...). Those tests actually exposed more problems in the original Scalar code: the SetValueFromData rout

[Lldb-commits] [PATCH] D19082: Store absolute path for lldb executable in dotest.py

fjricci created this revision. fjricci added reviewers: vharron, zturner, tfiala. fjricci added subscribers: sas, lldb-commits. lldb-server tests are currently being skipped on the check-lldb target. This is because we get the path of lldb-server by modifying the path to the lldb executable. How

Re: [Lldb-commits] [PATCH] D19004: Use the section sizes to determine symbols sizes in the Symtab instead of just using the following symbol's address

jasonmolenda closed this revision. jasonmolenda added a comment. Committed in r266165. Repository: rL LLVM http://reviews.llvm.org/D19004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

apelete created this revision. apelete added a subscriber: lldb-commits. The following warnings were reported while running clang analyzer on LLDB code base: API: argument with 'nonnull' attribute passed null, on file: - source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp. Dead store: dead as

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. These look like good changes to me, especially the SBThread fix - I'm surprised that hasn't caused a problem. The DynamicLoader change should be unnecessary but I don't have a problem with that. Tamas might want to sp

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

granata.enrico added a subscriber: granata.enrico. Comment at: source/Core/FormatEntity.cpp:1016 @@ -1015,2 +1015,3 @@ { -success &= item->DumpPrintableRepresentation(s,val_obj_display, custom_format); +if (item) +s

[Lldb-commits] [lldb] r266267 - Augment the 'language objc class-table dump' command to take a "-v" option, which makes it print ivar and method information, as well as an optional regex argument whic

Author: enrico Date: Wed Apr 13 19:43:20 2016 New Revision: 266267 URL: http://llvm.org/viewvc/llvm-project?rev=266267&view=rev Log: Augment the 'language objc class-table dump' command to take a "-v" option, which makes it print ivar and method information, as well as an optional regex argument

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. This revision now requires changes to proceed. Comment at: source/API/SBThread.cpp:926 @@ -925,3 +925,3 @@ Thread *thread = exe_ctx.GetThreadPtr(); -

Re: [Lldb-commits] [lldb] r266267 - Augment the 'language objc class-table dump' command to take a "-v" option, which makes it print ivar and method information, as well as an optional regex argument

I have just gotten a notification that this breaks the Android g++ bot: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/6443 The error seems like it’s at this line: aut

[Lldb-commits] [lldb] r266271 - Don't use auto - (try to) appease the Android g++ bot

Author: enrico Date: Wed Apr 13 20:23:01 2016 New Revision: 266271 URL: http://llvm.org/viewvc/llvm-project?rev=266271&view=rev Log: Don't use auto - (try to) appease the Android g++ bot Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Modifie

Re: [Lldb-commits] [lldb] r266271 - Don't use auto - (try to) appease the Android g++ bot

Hurray for the Android g++ bot! Sean > On Apr 13, 2016, at 6:23 PM, Enrico Granata via lldb-commits > wrote: > > Author: enrico > Date: Wed Apr 13 20:23:01 2016 > New Revision: 266271 > > URL: http://llvm.org/viewvc/llvm-project?rev=266271&view=rev > Log: > Don't use auto - (try to) appease t

[Lldb-commits] [PATCH] D19092: Fix Android build after r266267

ovyalov created this revision. ovyalov added a reviewer: granata.enrico. ovyalov added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. Fix Android build after r266267 http://reviews.llvm.org/D19092 Files: source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleO

[Lldb-commits] [lldb] r266274 - Fix Android build after r266267

Author: ovyalov Date: Wed Apr 13 21:02:12 2016 New Revision: 266274 URL: http://llvm.org/viewvc/llvm-project?rev=266274&view=rev Log: Fix Android build after r266267 Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Modified: lldb/trunk/sourc

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

ovyalov added a comment. Submitted as http://reviews.llvm.org/rL266274 http://reviews.llvm.org/D19092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

nitesh.jain added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1625-1626 @@ -1624,4 +1624,4 @@ if (arch_spec.GetMachine() == llvm::Triple::mips || arch_spec.GetMachine() == llvm::Triple::mipsel || arch_spec.G